Skip to content

Adding Laird BL654 as a new MTB target #8454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 18, 2018
Merged

Adding Laird BL654 as a new MTB target #8454

merged 3 commits into from
Oct 18, 2018

Conversation

ashok-rao
Copy link
Contributor

Description

NOTE: This PR is same as #8375 . Closing the previous one (8375) and creating this due to (possible) merge conflicts as commented by @cmonr here and here Adding new MTB target for Laird BL654.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

New Target addition for Laird BL654 module.

Greentea logs also attached here again for quick access.
BL654_ARMCC_GT_Pass_log.txt
BL654_GCC_GT_Pass_log.txt
BL654_IAR_GT_Pass_log.txt

@cmonr @0xc0170 : I'm now closing the PR #8375 and opening this one. Could you please re-review? Thanks.

Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor nits, and we can start CI

PinDef(0 , 31),

PinDef(1 , 0), //P1_1 = 32...
PinDef(1 , 1),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit. Could you fix the indentation?

//MTB aliases
GP0 = SIO_33,
GP1 = SIO_34,
AIN0 = SIO_2,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alignment nit

@ashok-rao
Copy link
Contributor Author

@cmonr : Thanks! Review comments now addressed!

@cmonr
Copy link
Contributor

cmonr commented Oct 17, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 17, 2018

Build : FAILURE

Build number : 3388
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8454/

@cmonr
Copy link
Contributor

cmonr commented Oct 17, 2018

This target is either missing QSPI pin definitions, or should not have QSPI marked as a supported feature.

@ashok-rao
Copy link
Contributor Author

Thanks @cmonr & @0xc0170 . QSPI pins now added. Can you please check again?

@cmonr
Copy link
Contributor

cmonr commented Oct 18, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 18, 2018

Build : SUCCESS

Build number : 3401
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8454/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Oct 18, 2018

@mbed-ci
Copy link

mbed-ci commented Oct 18, 2018

Test : SUCCESS

Build number : 3201
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8454/3201

@cmonr cmonr merged commit e942582 into ARMmbed:master Oct 18, 2018
@cmonr cmonr removed the needs: CI label Oct 18, 2018
@ashok-rao
Copy link
Contributor Author

Thanks @cmonr and @0xc0170 :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants