-
Notifications
You must be signed in to change notification settings - Fork 3k
Adding Laird BL654 as a new MTB target #8454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor nits, and we can start CI
PinDef(0 , 31), | ||
|
||
PinDef(1 , 0), //P1_1 = 32... | ||
PinDef(1 , 1), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit. Could you fix the indentation?
//MTB aliases | ||
GP0 = SIO_33, | ||
GP1 = SIO_34, | ||
AIN0 = SIO_2, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alignment nit
@cmonr : Thanks! Review comments now addressed! |
/morph build |
Build : FAILUREBuild number : 3388 |
This target is either missing QSPI pin definitions, or should not have QSPI marked as a supported feature. |
/morph build |
Build : SUCCESSBuild number : 3401 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 3031 |
Test : SUCCESSBuild number : 3201 |
Description
NOTE: This PR is same as #8375 . Closing the previous one (8375) and creating this due to (possible) merge conflicts as commented by @cmonr here and here Adding new MTB target for Laird BL654.
Pull request type
New Target addition for Laird BL654 module.
Greentea logs also attached here again for quick access.
BL654_ARMCC_GT_Pass_log.txt
BL654_GCC_GT_Pass_log.txt
BL654_IAR_GT_Pass_log.txt
@cmonr @0xc0170 : I'm now closing the PR #8375 and opening this one. Could you please re-review? Thanks.