[LoRaWAN]: Adding QOS in response to LinkADRReq and fixing class C bugs #8405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasnainvirk
changed the title
|
@AnttiKauppila, @cmonr Please review. |
|
@hasnainvirk Please take a look at the unittest. Looks like one of them is producing a segfault. |
added 8 commits
October 16, 2018 12:23
LinkADRReq parameters and certain parameters used camel case which is not the recommended style.
Before going after an automatic uplink, we should check if there was an automatic uplink already ongoing, i.e., the ack for the previous automatic uplink cycle has not been received. If there is we shouldn't queue the new automatic uplink and wait for the previous Ack cycle to complete.
LinkADRReq mac command can be used by the network server to set a certain level of QOS using NbTrans field which is applicable to Unconfirmed traffic only for 1.0.2 spec. This commit introduces mechanisms to facilitate this QOS. It means to repeat an outgoing unconfirmed message NbTrans times without changing its frame counter. For class C, we have retired the ack_expiry_timer_for_class_c and have replaced it with another timer which mimics the RX2 closure as in Class A but doesn't actually close RX2 window. It's just a mechanism by which the state machine is informed that the you can proceed forward, we have not received anything in RX2 window either. This is needed as RX2 doesn't timeout in class C (i.e., the radio remains in continuous mode). In addition to that we need to close any pending timers for Receive windows after the MIC has passed and the Duplicate counter check has also been passed.
After transmission we should change the state before invoking opening of slots as we may start receiving in the rx slots and the state would suddenly change from SENDING to RECEIVING without going through the ACK_WAIT state (in case of CONFIRMED messages). Tests show that after this slight adjustment, our number of ack retries have significantly reduced.
The idea behind the method post_process_no_reception() is to post process any outgoing TX but we shouldn't do that if a CONFIRMED message is outgoing and there are still some retries left.
Previously, we weren't filling in RX1 frequecny in rx_window1_config structure. However, everything worked as in LoRaPHY::rx_config() API there was a check which filled in correct RX1 frequency. Now we are filling in RX1 freq. properly while we are computing parameters for RX1 window.
A couple of the coverity analysis findings are being treated here. For the rest there will be a separate PR.
Missing methods are added. Logic was broken at various places which needed to be fixed.
hasnainvirk
force-pushed
the
QOS_impl_with_utests
branch
from
18a07e5 to
3bfef7f
Compare
hasnainvirk
changed the title
|
@hasnainvirk I re-ran the unit-test check and that still failed, then tried re-build on Jenkins as @OPpuolitaival suggested , but it still failed: |
Still failing, can you review the failures? @AnttiKauppila please review |
PR 8299 went in but correct unit tests were not there. This commit is adding proper unittests for 8299.
hasnainvirk
force-pushed
the
QOS_impl_with_utests
branch
from
8f0df13 to
9c3f73b
Compare
|
/morph build |
cmonr
approved these changes
Oct 16, 2018
Build : SUCCESSBuild number : 3372 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 3006 |
Test : SUCCESSBuild number : 3174 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds QOS mechanism for unconfirmed messages as per 1.0.2 spec in response to LinkADRReq mac command. In addition to that it fixes various bugs potentially hindering class C operation.
Unit tests for missing methods and fixes for broken logic in the unit tests is also added.
Pull request type