-
Notifications
You must be signed in to change notification settings - Fork 3k
Revert "Merge pull request #8299 from hasnainvirk/issue_8285" #8436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/morph build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hasnainvirk Can you provide details how this break the master?
Build : SUCCESSBuild number : 3364 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2998 |
Test : SUCCESSBuild number : 3168 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't revert. Merge this one instead #8405.
It has commits which fix all the issues with the unit tests which surfaced after the merge and revert of QOS PR.
@hasnainvirk I can give #8405 some time, but getting the unittest job unblocked is a priority so that we can continue bringing in other PRs. |
@hasnainvirk @OPpuolitaival , latest word from @0xc0170 is that this needs to be fixed today, if you can get #8405 working today then great, otherwise we will need to revert. |
Fixed with #8405 |
Description
Verifying something with CI. New jobs have been failing unittests, but have not been able to locally reproduce issue. Unless CI configuration has changed without warning, this is the only change that could be breaking the job, since it's it's the only LoRa change to be merged.
The particular CI failure did not occur until after the rollup PR was merged (in case anyone is wondering).
Pull request type