Skip to content

Revert "Merge pull request #8299 from hasnainvirk/issue_8285" #8436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

cmonr
Copy link
Contributor

@cmonr cmonr commented Oct 15, 2018

Description

Verifying something with CI. New jobs have been failing unittests, but have not been able to locally reproduce issue. Unless CI configuration has changed without warning, this is the only change that could be breaking the job, since it's it's the only LoRa change to be merged.

The particular CI failure did not occur until after the rollup PR was merged (in case anyone is wondering).

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

This reverts commit b666cd6, reversing
changes made to a9f4323.
@cmonr cmonr requested review from hasnainvirk and a team October 15, 2018 21:08
@cmonr
Copy link
Contributor Author

cmonr commented Oct 15, 2018

/morph build

@cmonr cmonr changed the title [DNM] Revert "Merge pull request #8299 from hasnainvirk/issue_8285" Revert "Merge pull request #8299 from hasnainvirk/issue_8285" Oct 15, 2018
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hasnainvirk Can you provide details how this break the master?

@mbed-ci
Copy link

mbed-ci commented Oct 16, 2018

Build : SUCCESS

Build number : 3364
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8436/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Oct 16, 2018

@mbed-ci
Copy link

mbed-ci commented Oct 16, 2018

Copy link
Contributor

@hasnainvirk hasnainvirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't revert. Merge this one instead #8405.
It has commits which fix all the issues with the unit tests which surfaced after the merge and revert of QOS PR.

@cmonr
Copy link
Contributor Author

cmonr commented Oct 16, 2018

@hasnainvirk I can give #8405 some time, but getting the unittest job unblocked is a priority so that we can continue bringing in other PRs.

@NirSonnenschein
Copy link
Contributor

@hasnainvirk @OPpuolitaival , latest word from @0xc0170 is that this needs to be fixed today, if you can get #8405 working today then great, otherwise we will need to revert.

@cmonr
Copy link
Contributor Author

cmonr commented Oct 16, 2018

Fixed with #8405

@cmonr cmonr closed this Oct 16, 2018
@cmonr cmonr removed the needs: CI label Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants