Skip to content

TOOLS : Add missing M33 and M33F in python scripts #8449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 7, 2018
Merged

TOOLS : Add missing M33 and M33F in python scripts #8449

merged 2 commits into from
Nov 7, 2018

Conversation

jeromecoutant
Copy link
Collaborator

Description

Tried to complete CORTEX_M33 coverage in python scripts.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

cmonr
cmonr approved these changes Oct 17, 2018
View reviewed changes
@cmonr cmonr requested a review from bridadan October 17, 2018 13:49
bridadan
bridadan approved these changes Oct 17, 2018
View reviewed changes
Copy link
Contributor

@bridadan bridadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super familiar with these cores yet, but the changes look ok to me.

deepikabhavnani
deepikabhavnani reviewed Oct 17, 2018
View reviewed changes
tools/toolchains/arm.py Outdated
@@ -413,6 +413,8 @@ def __init__(self, target, *args, **kwargs):
self.flags['common'].append("-mfloat-abi=softfp")
elif target.core.startswith("Cortex-M23"):
self.flags['common'].append("-march=armv8-m.base")
elif target.core.startswith("Cortex-M33"):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cortex-M33 CPU specific flags are covered here.. https://github.com/ARMmbed/mbed-os/pull/8449/files#diff-9cf75aea879b6b9cc5026af0b8f708a3R396

No need of arch flag for M33 as we give add cpu flag, we should be just adding floating point here for F option.

Just FYI- Special case of non-floating point related is covered here for Cortex-M23 since we do not specify CPU but arch only. Can still be moved here https://github.com/ARMmbed/mbed-os/pull/8449/files#diff-9cf75aea879b6b9cc5026af0b8f708a3R403.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-mcpu=cortex-m33+nodsp and -mfpu=none Is already set, so addition of -march is not needed here. Code should be updated to:

elif target.core.startswith("Cortex-M33F"): 
    self.flags['common'].append("-mfpu=fpv5-sp-d16")
    self.flags['common'].append("-mfloat-abi=softfp")

deepikabhavnani
deepikabhavnani reviewed Oct 17, 2018
View reviewed changes
@0xc0170
Copy link
Contributor

0xc0170 commented Oct 25, 2018

@jeromecoutant Can you please review the latest @deepikabhavnani review?

@jeromecoutant
Copy link
Collaborator Author

Can you please review the latest @deepikabhavnani review?

Mmm, not easy for me... I am not a M33 expert...
I started this PR, I would trust ARM expert for conclusion

deepikabhavnani
deepikabhavnani reviewed Oct 26, 2018
View reviewed changes
@cmonr
Copy link
Contributor

cmonr commented Oct 29, 2018

@theotherjimmy Mind reviewing?

@jeromecoutant
Copy link
Collaborator Author

Hi @deepikabhavnani
I tried to update files thanks to your comment.
Thx

deepikabhavnani
deepikabhavnani suggested changes Nov 5, 2018
View reviewed changes
Copy link

@deepikabhavnani deepikabhavnani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeromecoutant - Changes look good, just small nit for code duplication

deepikabhavnani
deepikabhavnani reviewed Nov 5, 2018
View reviewed changes
@jeromecoutant
Copy link
Collaborator Author

I squashed all your suggestion

@cmonr cmonr mentioned this pull request Nov 7, 2018
Merged
@cmonr
Copy link
Contributor

cmonr commented Nov 7, 2018

Note: This PR is now a part of a rollup PR (#8663).

No further work is needed here, as once that PR is merged, this PR will also be closed and marked as merged.

If any more commits are made in this PR, this PR will remain open and have to go through CI on its own.

@0xc0170 0xc0170 merged commit ba86a53 into ARMmbed:master Nov 7, 2018
@0xc0170 0xc0170 removed the needs: CI label Nov 7, 2018
@jeromecoutant jeromecoutant deleted the PR_M33 branch November 7, 2018 08:01
@cmonr cmonr removed the rollup PR label Nov 7, 2018
@deepikabhavnani deepikabhavnani mentioned this pull request Nov 13, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 left review comments

@cmonr cmonr cmonr approved these changes

@bridadan bridadan bridadan approved these changes

@deepikabhavnani deepikabhavnani deepikabhavnani approved these changes

@theotherjimmy theotherjimmy Awaiting requested review from theotherjimmy

Assignees
No one assigned
Labels
release-version: 5.10.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jeromecoutant @0xc0170 @cmonr @bridadan @deepikabhavnani