-
Notifications
You must be signed in to change notification settings - Fork 3k
Adding arch option instead MCPU for no dsp and no fpu support #8729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
No FPU option is valid, but supported only for 8.x releases, with 7.x release +nofp gives build errors.
@deepikabhavnani I thought it was mentioned in a different PR that |
We have few Cortex-M33 with optional floating point and DSP, the mcpu option by default enables optional features. To disable optional features we need to add +nodsp +nofp. But in tools if we set core as cortex-M33 it is without optional features, to select particular feature we need to explicitly append In 8449, Cortex-M33F was added and Cortex-M33 was updated. Cortex-M33 = cortex-m33+nodsp+nofp - But Cortex-M33F= cortex-m33+nodsp - This enables floating point for 8449. Hope this helps. |
Musca-A GCC_ARM build is working as expected with this fix. |
@deepikabhavnani Could you clarify the description for this PR please.
This is not very clear especially to the casual observer. |
/morph build |
Build : SUCCESSBuild number : 3622 Triggering tests/morph test |
@adbridge @deepikabhavnani So we shouldn't use +nofp for Cortex-M33 until GCC 8 is released for M class processors and if it's released and its features used by mbed build, the corresponding compiler version should be enforced by the build system. |
Exporter Build : FAILUREBuild number : 3230 |
Test : FAILUREBuild number : 3406 |
@ARMmbed/mbed-os-maintainers - Failures does not look like related to PR, is it some CI issue ? |
That is correct, I'll add this to the new rollup PR to restart testing there |
Note: This PR is now a part of a rollup PR (#8753). In order to expedite remaining CI testing, this PR has been bundled into the above rollup PR. No further work is needed here, as once that PR is merged, this PR will also be closed and marked as merged. If any more commits are made in this PR, this PR will remain open and have to go through CI on its own. |
Please ignore. I derped. |
Description
Cortex-M33 has optional floating point and DSP, the mcpu option by default enables optional features. To disable optional features we need to add +nodsp +nofp.
But nofp is supported after 8.x version of toolchain. Hence to get this we will have to use -march option instead of -mcpu
Pull request type