-
Notifications
You must be signed in to change notification settings - Fork 3k
BLE: fix using an optional feature before checking for support #8556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/morph build |
Build : SUCCESSBuild number : 3486 Triggering tests/morph test |
Exporter Build : FAILUREBuild number : 3104 |
Test : FAILUREBuild number : 3272 |
Might have had an issue with the Jenkins instance. Restarting to confirm. /morph export-build |
Exporter Build : SUCCESSBuild number : 3106 |
/morph build |
Build : SUCCESSBuild number : 3488 Triggering tests/morph test |
Exporter Build : FAILUREBuild number : 3107 |
IAR Lincense error in the first log I looked into. |
good point: re-running export: /morph export-build |
/morph mbed2-build |
Test : FAILUREBuild number : 3274 |
To confirm the issue (not related to this changeset but rather to master) /morph test |
Exporter Build : SUCCESSBuild number : 3108 |
Test : SUCCESSBuild number : 3276 |
Description
Feature is optional and we must check the controller for support before trying to use it. Detected and fix validated through clitest suite of BLE tests.
Pull request type