Skip to content

BLE: fix using an optional feature before checking for support #8556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2018
Merged

BLE: fix using an optional feature before checking for support #8556

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions features/FEATURE_BLE/targets/TARGET_CORDIO/source/CordioPalGap.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,8 +334,12 @@ ble_error_t Gap::set_address_resolution(
}

ble_error_t Gap::read_phy(connection_handle_t connection) {
DmReadPhy(connection);
return BLE_ERROR_NONE;
if (is_feature_supported(ControllerSupportedFeatures_t::LE_2M_PHY)
|| is_feature_supported(ControllerSupportedFeatures_t::LE_CODED_PHY)) {
DmReadPhy(connection);
return BLE_ERROR_NONE;
}
return BLE_ERROR_NOT_IMPLEMENTED;
}

ble_error_t Gap::set_preferred_phys(
Expand Down