Skip to content

Compile time config flag MBED_CONF_SD_CRC_ENABLED for CRC in SD #8573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 9, 2018
Merged

Compile time config flag MBED_CONF_SD_CRC_ENABLED for CRC in SD #8573

merged 2 commits into from
Nov 9, 2018

Conversation

deepikabhavnani
Copy link

@deepikabhavnani deepikabhavnani commented Oct 29, 2018 •
edited
Loading

Description

CRC class adds to the ROM size even when disabled runtime, because addition of ROM tables.
Addition a compile time option to disable CRC is required for reducing code size of SD driver component.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Not sure if this is breaking change, though CRC functionality was added but default was disabled as runtime option and now it will be disabled as default with compile time option. Config option in mbed_lib.json provides CRC feature as default.

@deepikabhavnani deepikabhavnani changed the title Compile time flag MBED_SD_CRC_ENABLE for CRC in SD Compile time config flag MBED_CONF_SD_CRC_ENABLED for CRC in SD Oct 29, 2018
@cmonr cmonr requested review from a team and 0xc0170 October 29, 2018 23:10
bulislaw
bulislaw reviewed Oct 30, 2018
View reviewed changes
components/storage/blockdevice/COMPONENT_SD/config/mbed_lib.json
@@ -8,7 +8,8 @@
"FSFAT_SDCARD_INSTALLED": 1,
"CMD_TIMEOUT": 10000,
"CMD0_IDLE_STATE_RETRIES": 5,
"SD_INIT_FREQUENCY": 100000
"INIT_FREQUENCY": 100000,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did the the name change?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial name setting was a typo, "SD_" was not needed as the tools append "MBED_CONF_SD_" for all the config options, with old name the macro would be "MBED_CONF_SD_SD_INIT_FREQUENCY"

@bulislaw bulislaw requested review from offirko and geky October 30, 2018 10:15
deepikabhavnani added 2 commits November 6, 2018 10:53
Compile time flag MBED_SD_CRC_ENABLE for CRC in SD
a0f3fdc 
CRC class adds to the ROM size even when disabled runtime, because
of addition of ROM tables. Addition a compile time option to disable
CRC is required for reducing code size of SD driver component.

Library config option `SD_CRC_ENABLED` is added, set it to 0 to
disable CRC feature in SD.
Corrected INIT_FREQUENCY macro SD is appended by tools
e7bdf3c
@deepikabhavnani
Copy link
Author

Rebased to resolve conflicts.

@ARMmbed/mbed-os-storage @geky @offirko - Please review

offirko
offirko approved these changes Nov 7, 2018
View reviewed changes
Copy link
Contributor

@offirko offirko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks

geky
geky approved these changes Nov 7, 2018
View reviewed changes
Copy link
Contributor

@geky geky left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wooh!

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 8, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Nov 8, 2018

Build : SUCCESS

Build number : 3583
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8573/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Nov 8, 2018

Exporter Build : SUCCESS

Build number : 3193
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8573/

@mbed-ci
Copy link

mbed-ci commented Nov 8, 2018

Test : FAILURE

Build number : 3357
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8573/3357

@deepikabhavnani
Copy link
Author

Not sure what happened to KW41Z, does not look related to this PR

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 8, 2018

/morph test

@cmonr cmonr mentioned this pull request Nov 9, 2018
Merged
@cmonr
Copy link
Contributor

cmonr commented Nov 9, 2018

Note: This PR is now a part of a rollup PR (#8686).

No further work is needed here, as once that PR is merged, this PR will also be closed and marked as merged.

If any more commits are made in this PR, this PR will remain open and have to go through CI on its own.

@mbed-ci
Copy link

mbed-ci commented Nov 9, 2018

Test : SUCCESS

Build number : 3360
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8573/3360

@cmonr cmonr merged commit 72253b7 into ARMmbed:master Nov 9, 2018
@deepikabhavnani deepikabhavnani deleted the flag_Crc branch November 9, 2018 21:43
@adbridge
Copy link
Contributor

This is on top of 5.11 changes

@deepikabhavnani deepikabhavnani mentioned this pull request Dec 27, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bulislaw bulislaw bulislaw left review comments

@geky geky geky approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@offirko offirko offirko approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@deepikabhavnani @0xc0170 @mbed-ci @cmonr @adbridge @bulislaw @geky @offirko