Skip to content

Rollup PR: #8686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Nov 9, 2018
Merged

Rollup PR: #8686

merged 22 commits into from
Nov 9, 2018

Conversation

mmahadevan108 and others added 22 commits October 24, 2018 08:20
Handle the case where the number of bytes to write is not aligned
to page size

Signed-off-by: Mahesh Mahadevan <[email protected]>
1. Add missing SPI and I2C pins.
2. Remove pin definitions for pins that are no connects.
CRC class adds to the ROM size even when disabled runtime, because
of addition of ROM tables. Addition a compile time option to disable
CRC is required for reducing code size of SD driver component.

Library config option `SD_CRC_ENABLED` is added, set it to 0 to
disable CRC feature in SD.
Signed-off-by: Mahesh Mahadevan <[email protected]>
### Description

The prior logic assumed that "." would not be added to the include
paths, indicating that the project root would not be added to the
include paths correctly in the online environment ("." would be
incorrect there). This change set started by removing the addition
of "*.", and then fixed building from there.

### Pull request type

    [x] Fix
    [ ] Refactor
    [ ] Target update
    [ ] Functionality change
    [ ] Docs update
    [ ] Test update
    [ ] Breaking change
Sync mbed-client-cli with master repo v0.4.0.
### Description

The prior fix made the assumption that you wanted to compute all of the
parents for a give header file going all the way up the path. This is
not true: you probably want to stop when the project stops. We already
keep track of a virtual name within the project, so instead, we compute
parents of the name, and generate the actual location of these files in
your FS as the path. This makes the solution robust offline and online
(I tested it with my local copy of os.mbed.com)

### Pull request type

    [x] Fix
    [ ] Refactor
    [ ] Target update
    [ ] Functionality change
    [ ] Docs update
    [ ] Test update
    [ ] Breaking change
@cmonr cmonr requested a review from a team November 9, 2018 00:25
@cmonr
Copy link
Contributor Author

cmonr commented Nov 9, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Nov 9, 2018

Build : SUCCESS

Build number : 3586
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8686/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Nov 9, 2018

@mbed-ci
Copy link

mbed-ci commented Nov 9, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 9, 2018

One board went down, restarting

/morph test

@mbed-ci
Copy link

mbed-ci commented Nov 9, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 9, 2018

2 failures:

NRF52_DK-GCC_ARM.tests-mbed_hal-rtc_time_conv.test make time and local time - RTC leap years partial support
NRF52_DK-IAR.tests-mbed_hal-rtc_time_conv.test make time and local time - RTC leap years full support

I could not locate any issue for these, and recall seeing this RTC previously. @mprse this timeout in the test case, have you experienced it or can you reproduce locally?

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 9, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Nov 9, 2018

@cmonr cmonr merged commit 44ee9a7 into ARMmbed:master Nov 9, 2018
@cmonr cmonr removed the needs: CI label Nov 9, 2018
@cmonr cmonr deleted the rollup branch November 9, 2018 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants