Skip to content

STM32F4: Add support of the new USB Device API #8583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 6, 2018
Merged

STM32F4: Add support of the new USB Device API #8583

merged 3 commits into from
Nov 6, 2018

Conversation

bcostm
Copy link
Contributor

@bcostm bcostm commented Oct 30, 2018 •
edited
Loading

Description

Applied the same patch in CubeF4 as done in CubeF2 for the NUCLEO_F207ZG (see PR #7322 )

tests-usb_device-basic tests are OK on ARM, IAR and GCC_ARM

USB Device enabled on the following platforms:

  • NUCLEO_F412ZG
  • NUCLEO_F413ZH
  • NUCLEO_F429ZI
  • NUCLEO_F446ZE
  • DISCO_F413ZH
  • DISCO_F469NI

Pull request type

[ ] Fix
[ ] Refactor
[X] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@0xc0170 0xc0170 requested a review from c1728p9 October 30, 2018 11:33
@bcostm bcostm changed the title NUCLEO_F412ZG: Add support of the new USB Device API STM32: Add support of the new USB Device API Oct 30, 2018
@bcostm bcostm changed the title STM32: Add support of the new USB Device API STM32F4: Add support of the new USB Device API Oct 30, 2018
@bcostm bcostm force-pushed the F4_feature-hal-spec-usb-device branch 2 times, most recently from 5d23225 to 4774061 Compare October 30, 2018 13:01
@0xc0170
Copy link
Contributor

0xc0170 commented Oct 31, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 31, 2018

Build : FAILURE

Build number : 3517
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8583/

@NirSonnenschein
Copy link
Contributor

@bcostm , this looks like a build configuration issue:
[DEBUG] Return: 1
[DEBUG] Output: "./TESTS/mbedmicro-rtos-mbed/systimer/main.cpp", line 17: Error: #35: #error directive: [NOT_SUPPORTED] Tickless mode not supported for this target.
[DEBUG] Output: ./TESTS/mbedmicro-rtos-mbed/systimer/main.cpp: 0 warnings, 1 error
Building project udp (K64F, ARM)

please take a look.

@bcostm
Copy link
Contributor Author

bcostm commented Nov 2, 2018

I don't know what to do ? My changes are not related to the K64F platform nor the tickless feature...

@c1728p9 c1728p9 force-pushed the feature-hal-spec-usb-device branch from 05d77ab to aa0cdea Compare November 2, 2018 23:30
@cmonr
Copy link
Contributor

cmonr commented Nov 3, 2018 •
edited
Loading

@bcostm @c1728p9 Rebase the feature branch just yesterday. Go ahead and rebase your PR, and we can get CI restarted.

@NirSonnenschein
Copy link
Contributor

@bcostm , this probably needs a rebase, please take a look

bcostm added 3 commits November 5, 2018 10:34
@bcostm
STM32F4 USB: add patch in CubeF4 hal driver
3d0cc39
@bcostm
STM32F4 USB: remove useless macro
074aab6
@bcostm
STM32F4 USB: enable USB Device in targets.json
e1fd678 
tests-usb_device-basic are OK on the following platforms:

NUCLEO_F412ZG
NUCLEO_F413ZH
NUCLEO_F429ZI
NUCLEO_F446ZE
DISCO_F413ZH
DISCO_F469NI
@bcostm bcostm force-pushed the F4_feature-hal-spec-usb-device branch from 4774061 to e1fd678 Compare November 5, 2018 09:41
@bcostm
Copy link
Contributor Author

bcostm commented Nov 5, 2018

Rebase done

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 6, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Nov 6, 2018

Build : SUCCESS

Build number : 3549
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8583/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Nov 6, 2018

Exporter Build : SUCCESS

Build number : 3160
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8583/

@mbed-ci
Copy link

mbed-ci commented Nov 6, 2018

Test : SUCCESS

Build number : 3333
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8583/3333

@0xc0170 0xc0170 merged commit c6b68a6 into ARMmbed:feature-hal-spec-usb-device Nov 6, 2018
This was referenced Nov 7, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c1728p9 c1728p9 c1728p9 approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: feature branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bcostm @0xc0170 @mbed-ci @NirSonnenschein @cmonr @c1728p9