STM32F7: Add support of the new USB Device API #8688

bcostm · 2018-11-09T10:39:49Z

Description

Enable new USB Device API on the following STM32F7 platforms:

NUCLEO_F746ZG
NUCLEO_F756ZG
NUCLEO_F767ZI
DISCO_F746NG (HS + FS)
DISCO_F769NI

The same USB HAL patch as done for STM32F2, STM32F4 and STM32L4 has been applied (see PRs #7322
#8583 #8665)

Tests

tests-usb_device-basic tests are OK on ARM, IAR and GCC_ARM
tests-usb_device-serial tests are FAIL

Pull request type

[ ] Fix
[ ] Refactor
[X] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

jeromecoutant · 2018-11-09T12:46:17Z

usb/device/targets/TARGET_STM/USBPhy_STM32.cpp

    pin_function(PA_10, STM_PIN_DATA(STM_MODE_AF_OD, GPIO_PULLUP, GPIO_AF10_OTG_FS)); // ID
    pin_function(PA_8, STM_PIN_DATA(STM_MODE_AF_PP, GPIO_NOPULL, GPIO_AF10_OTG_FS));  // SOF
    __HAL_RCC_USB_OTG_FS_CLK_ENABLE();

 #elif defined(TARGET_DISCO_F429ZI)
-    __HAL_RCC_GPIOB_CLK_ENABLE();


This is not related to F7 ?

no, this means you should test again F429 ?

Commit removed. Discussion closed...

adbridge · 2018-11-14T15:19:50Z

@c1728p9 This has been waiting review for 5 days could you please take a look asap?

c1728p9 · 2018-11-14T20:32:02Z

targets/TARGET_STM/TARGET_STM32F7/device/stm32f7xx_hal_pcd.c

@@ -300,10 +302,10 @@ __weak void HAL_PCD_MspDeInit(PCD_HandleTypeDef *hpcd)
  */
 HAL_StatusTypeDef HAL_PCD_Start(PCD_HandleTypeDef *hpcd)
 {
-  __HAL_LOCK(hpcd);


Why was the lock removed?

It has been removed in the F4 (and L4 I think too) so I just did the same. Do you think it can cause a problem ?

I don't see it being removed in the F4. Can you link to the PR which did this? If there isn't a good reason for removing this I would recommend leaving the lock in.

I will double-check the PCD Init,Start, Stop functions between the F2, F4, F7 and L4 devices and align them. I will send this change in a separate PR.

c1728p9 · 2018-11-14T20:32:30Z

targets/TARGET_STM/TARGET_STM32F7/device/stm32f7xx_hal_pcd.c

@@ -148,8 +149,9 @@ HAL_StatusTypeDef HAL_PCD_Init(PCD_HandleTypeDef *hpcd)
  {
    /* Allocate lock resource and initialize it */
    hpcd->Lock = HAL_UNLOCKED;
-	for (i = 0; i < hpcd->Init.dev_endpoints ; i++)
-	hpcd->EPLock[i].Lock = HAL_UNLOCKED;
+    for (i = 0; i < hpcd->Init.dev_endpoints ; i++) { // MBED PATCH


I didn't see this change in the other PRs. Is this just cosmetic?

Yes just cosmetic

Is this change going to be upstreamed into the cube library? If not you may just want to leave this how it was to minimize the difference between the the cube library and the mbed fork.

0xc0170 · 2018-11-16T10:16:44Z

Info: This PR has been re-bundled into a new rollup PR (#8768).

No further work is needed here, as once that PR is merged, this PR will also be closed and marked as merged.
If any more commits are made in this PR, this PR will remain open and have to go through CI on its own.

cmonr · 2018-11-16T15:41:44Z

@bcostm It looks like both PRs in the last rollup PR had issues. Please take a look at the F7-related build failures: #8768 (comment)

bcostm · 2018-11-20T09:25:05Z

I have rebased and added the NUCLEO_F756ZG board to fix the build error seen on this board during the Rollup PR.

cmonr · 2018-11-22T02:12:32Z

Starting CI

0xc0170 · 2018-11-22T10:10:20Z

I stoped the job, there are few other items that have dependency on features for 5.11, this will be restarted later (might take few days if that is OK, as we are close to the weekend)

OPpuolitaival · 2018-11-22T11:14:36Z

.tests-usb_device-serial.CDC USB reconnect test is only one which fails in multiple boards.. seems that this PR is related to that area. Please check what is root cause

Test Result (15 failures / +15)
ARCH_PRO iar_arm / ARCH_PRO-IAR.tests-usb_device-serial.CDC USB reconnect
ARCH_PRO armcc / ARCH_PRO-ARM.tests-usb_device-serial.CDC USB reconnect
ARCH_PRO arm-none-eabi-gcc / ARCH_PRO-GCC_ARM.tests-usb_device-serial.CDC USB reconnect
NUCLEO_F207ZG iar_arm / NUCLEO_F207ZG-IAR.tests-usb_device-serial.CDC USB reconnect
NUCLEO_F207ZG armcc / NUCLEO_F207ZG-ARM.tests-usb_device-serial.CDC USB reconnect
NUCLEO_F746ZG iar_arm / NUCLEO_F746ZG-IAR.tests-usb_device-serial.CDC USB reconnect
NUCLEO_F207ZG arm-none-eabi-gcc / NUCLEO_F207ZG-GCC_ARM.tests-usb_device-serial.CDC USB reconnect
NUCLEO_F746ZG armcc / NUCLEO_F746ZG-ARM.tests-usb_device-serial.CDC USB reconnect
NUCLEO_F746ZG arm-none-eabi-gcc / NUCLEO_F746ZG-GCC_ARM.tests-usb_device-serial.CDC USB reconnect
NUCLEO_F429ZI arm-none-eabi-gcc / NUCLEO_F429ZI-GCC_ARM.tests-usb_device-serial.CDC USB reconnect
NUCLEO_F429ZI armcc / NUCLEO_F429ZI-ARM.tests-usb_device-serial.CDC USB reconnect
NUCLEO_F429ZI iar_arm / NUCLEO_F429ZI-IAR.tests-usb_device-serial.CDC USB reconnect
K64F iar_arm / K64F-IAR.tests-usb_device-serial.CDC USB reconnect
K64F armcc / K64F-ARM.tests-usb_device-serial.CDC USB reconnect
K64F arm-none-eabi-gcc / K64F-GCC_ARM.tests-usb_device-serial.CDC USB reconnect

bcostm · 2018-11-22T13:33:02Z

I only ran tests-usb_device-basic tests. There is maybe additional work to do for the Serial tests to PASS... @c1728p9 did you run the Serial tests on the NUCLEO_F207ZG board when you did the PR #7322 ?

cmonr · 2018-12-10T16:57:31Z

@c1728p9 Mind helping out?

c1728p9 · 2018-12-19T21:47:49Z

Hi @bcostm I rebased the USB feature branch to bring in a fix for the serial test when running with IAR. Because of this you'll need to rebase this PR.

@c1728p9 did you run the Serial tests on the NUCLEO_F207ZG board when you did the PR #7322 ?

Nope, the serial test wasn't written at that time. I did run it as part of the feature branch rebase. It passed all the USB tests - serial and basic:

mbedgt: test suite report:
| target            | platform_name | test suite              | result | elapsed_time (sec) | copy_method |
|-------------------|---------------|-------------------------|--------|--------------------|-------------|
| NUCLEO_F207ZG-ARM | NUCLEO_F207ZG | tests-usb_device-basic  | OK     | 84.42              | default     |
| NUCLEO_F207ZG-ARM | NUCLEO_F207ZG | tests-usb_device-serial | OK     | 51.34              | default     |
mbedgt: test suite results: 2 OK
mbedgt: test case report:
| target            | platform_name | test suite              | test case                                  | passed | failed | result | elapsed_time (sec) |
|-------------------|---------------|-------------------------|--------------------------------------------|--------|--------|--------|--------------------|
| NUCLEO_F207ZG-ARM | NUCLEO_F207ZG | tests-usb_device-basic  | endpoint test abort                        | 1      | 0      | OK     | 16.63              |
| NUCLEO_F207ZG-ARM | NUCLEO_F207ZG | tests-usb_device-basic  | endpoint test data correctness             | 1      | 0      | OK     | 1.37               |
| NUCLEO_F207ZG-ARM | NUCLEO_F207ZG | tests-usb_device-basic  | endpoint test data toggle reset            | 1      | 0      | OK     | 0.68               |
| NUCLEO_F207ZG-ARM | NUCLEO_F207ZG | tests-usb_device-basic  | endpoint test halt                         | 1      | 0      | OK     | 10.26              |
| NUCLEO_F207ZG-ARM | NUCLEO_F207ZG | tests-usb_device-basic  | endpoint test parallel transfers           | 1      | 0      | OK     | 4.72               |
| NUCLEO_F207ZG-ARM | NUCLEO_F207ZG | tests-usb_device-basic  | endpoint test parallel transfers ctrl      | 1      | 0      | OK     | 5.05               |
| NUCLEO_F207ZG-ARM | NUCLEO_F207ZG | tests-usb_device-basic  | usb control basic test                     | 1      | 0      | OK     | 0.76               |
| NUCLEO_F207ZG-ARM | NUCLEO_F207ZG | tests-usb_device-basic  | usb control sizes test                     | 1      | 0      | OK     | 0.69               |
| NUCLEO_F207ZG-ARM | NUCLEO_F207ZG | tests-usb_device-basic  | usb control stall test                     | 1      | 0      | OK     | 0.66               |
| NUCLEO_F207ZG-ARM | NUCLEO_F207ZG | tests-usb_device-basic  | usb control stress test                    | 1      | 0      | OK     | 0.9                |
| NUCLEO_F207ZG-ARM | NUCLEO_F207ZG | tests-usb_device-basic  | usb device reset test                      | 1      | 0      | OK     | 2.48               |
| NUCLEO_F207ZG-ARM | NUCLEO_F207ZG | tests-usb_device-basic  | usb repeated construction destruction test | 1      | 0      | OK     | 2.99               |
| NUCLEO_F207ZG-ARM | NUCLEO_F207ZG | tests-usb_device-basic  | usb soft reconnection test                 | 1      | 0      | OK     | 2.55               |
| NUCLEO_F207ZG-ARM | NUCLEO_F207ZG | tests-usb_device-serial | CDC RX multiple bytes                      | 1      | 0      | OK     | 3.06               |
| NUCLEO_F207ZG-ARM | NUCLEO_F207ZG | tests-usb_device-serial | CDC RX multiple bytes concurrent           | 1      | 0      | OK     | 3.7                |
| NUCLEO_F207ZG-ARM | NUCLEO_F207ZG | tests-usb_device-serial | CDC RX single bytes                        | 1      | 0      | OK     | 0.54               |
| NUCLEO_F207ZG-ARM | NUCLEO_F207ZG | tests-usb_device-serial | CDC RX single bytes concurrent             | 1      | 0      | OK     | 0.72               |
| NUCLEO_F207ZG-ARM | NUCLEO_F207ZG | tests-usb_device-serial | CDC USB reconnect                          | 1      | 0      | OK     | 1.71               |
| NUCLEO_F207ZG-ARM | NUCLEO_F207ZG | tests-usb_device-serial | CDC loopback                               | 1      | 0      | OK     | 1.52               |
| NUCLEO_F207ZG-ARM | NUCLEO_F207ZG | tests-usb_device-serial | Serial USB reconnect                       | 1      | 0      | OK     | 1.78               |
| NUCLEO_F207ZG-ARM | NUCLEO_F207ZG | tests-usb_device-serial | Serial getc                                | 1      | 0      | OK     | 0.64               |
| NUCLEO_F207ZG-ARM | NUCLEO_F207ZG | tests-usb_device-serial | Serial line coding change                  | 1      | 0      | OK     | 1.07               |
| NUCLEO_F207ZG-ARM | NUCLEO_F207ZG | tests-usb_device-serial | Serial printf/scanf                        | 1      | 0      | OK     | 2.05               |
| NUCLEO_F207ZG-ARM | NUCLEO_F207ZG | tests-usb_device-serial | Serial terminal reopen                     | 1      | 0      | OK     | 0.92               |
mbedgt: test case results: 24 OK
mbedgt: completed in 141.11 sec

bcostm · 2018-12-20T12:02:30Z

Thanks @c1728p9
I have rebased my branch but Serial tests are still fail (tested on DISCO_F769NI platform). Basic USB tests are OK.

I have tested the NUCLEO_F207ZG/ARM and the Serial tests are also FAIL while they are PASS for you. Humm something's wrong with my setup 😕

0xc0170 · 2019-01-17T13:49:05Z

We will start CI for this feature branch addition (to my understanding this is all fine for the feature branch)

0xc0170 · 2019-01-17T16:42:44Z

CI started

mbed-ci · 2019-01-17T21:17:51Z

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 4
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_dynamic-memory-usage

cmonr · 2019-01-18T00:35:48Z

CI job restarted: jenkins-ci/mbed-os-ci_dynamic-memory-usage

(Evne thought this still needs a rebase)

bcostm · 2019-01-18T09:26:46Z

Rebased

0xc0170 · 2019-01-18T13:44:59Z

CI started

mbed-ci · 2019-01-19T03:21:28Z

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 5
Build artifacts

jeromecoutant reviewed Nov 9, 2018

View reviewed changes

0xc0170 added the needs: review label Nov 9, 2018

bcostm force-pushed the F7_feature-hal-spec-usb-device branch from 21a6b61 to 4c300e7 Compare November 9, 2018 13:17

jeromecoutant approved these changes Nov 9, 2018

View reviewed changes

0xc0170 requested a review from c1728p9 November 9, 2018 13:41

adbridge added the release-version: feature branch label Nov 14, 2018

c1728p9 approved these changes Nov 14, 2018

View reviewed changes

0xc0170 added needs: CI and removed needs: review labels Nov 15, 2018

NirSonnenschein added ready for merge and removed needs: CI labels Nov 15, 2018

0xc0170 added needs: CI rollup PR: B and removed ready for merge labels Nov 15, 2018

0xc0170 mentioned this pull request Nov 16, 2018

Rollup USB STM32 #8768

Closed

cmonr removed the rollup PR: B label Nov 16, 2018

cmonr added needs: work and removed needs: CI labels Nov 16, 2018

bcostm force-pushed the F7_feature-hal-spec-usb-device branch from 4c300e7 to 9039079 Compare November 20, 2018 09:23

cmonr added needs: CI and removed needs: work labels Nov 21, 2018

0xc0170 added the needs: work label Nov 26, 2018

bcostm force-pushed the F7_feature-hal-spec-usb-device branch from 5e4890d to 6bfe9ea Compare December 12, 2018 16:24

c1728p9 force-pushed the feature-hal-spec-usb-device branch from 65d71bb to 0e5dd39 Compare December 19, 2018 21:27

bcostm force-pushed the F7_feature-hal-spec-usb-device branch from 6bfe9ea to 3253654 Compare December 20, 2018 11:59

0xc0170 added needs: CI and removed needs: work labels Jan 17, 2019

c1728p9 force-pushed the feature-hal-spec-usb-device branch from 8b6fffb to 15f9389 Compare January 17, 2019 21:16

cmonr added needs: work and removed needs: CI labels Jan 18, 2019

bcostm added 4 commits January 18, 2019 10:23

STM32F7 USB: add patch in CubeF7 hal driver

e37ee0f

STM32F7 USB: change VBUS pin for DISCO_F746NG FS

5f8a230

STM32F7 USB: add NUCLEO_F756ZG in pins definition

6030dc7

STM32F7 USB: enable USBDEVICE in targets.json

ce6834f

bcostm force-pushed the F7_feature-hal-spec-usb-device branch from 3253654 to ce6834f Compare January 18, 2019 09:23

0xc0170 added needs: CI and removed needs: work labels Jan 18, 2019

0xc0170 added ready for merge and removed needs: CI labels Jan 21, 2019

0xc0170 merged commit ab4f5e3 into ARMmbed:feature-hal-spec-usb-device Jan 21, 2019

0xc0170 removed the ready for merge label Jan 21, 2019

bcostm deleted the F7_feature-hal-spec-usb-device branch January 22, 2019 14:00

STM32F7: Add support of the new USB Device API #8688

STM32F7: Add support of the new USB Device API #8688

Uh oh!

Conversation

bcostm commented Nov 9, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Tests

Pull request type

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adbridge commented Nov 14, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Nov 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmonr commented Nov 16, 2018

Uh oh!

bcostm commented Nov 20, 2018

Uh oh!

cmonr commented Nov 22, 2018

Uh oh!

0xc0170 commented Nov 22, 2018

Uh oh!

OPpuolitaival commented Nov 22, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bcostm commented Nov 22, 2018

Uh oh!

cmonr commented Dec 10, 2018

Uh oh!

c1728p9 commented Dec 19, 2018

Uh oh!

bcostm commented Dec 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xc0170 commented Jan 17, 2019

Uh oh!

0xc0170 commented Jan 17, 2019

Uh oh!

mbed-ci commented Jan 17, 2019

Uh oh!

cmonr commented Jan 18, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bcostm commented Jan 18, 2019

Uh oh!

0xc0170 commented Jan 18, 2019

Uh oh!

mbed-ci commented Jan 19, 2019

Uh oh!

Uh oh!

bcostm commented Nov 9, 2018 •

edited

Loading

0xc0170 commented Nov 16, 2018 •

edited

Loading

OPpuolitaival commented Nov 22, 2018 •

edited

Loading

bcostm commented Dec 20, 2018 •

edited

Loading

cmonr commented Jan 18, 2019 •

edited

Loading