Fetch ram/rom start/size #8607

aashishc1988 · 2018-10-31T21:24:01Z

Description

Fetch rom/ram start/size information and create defines for the same.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

aashishc1988 · 2018-10-31T21:24:18Z

@theotherjimmy @deepikabhavnani

theotherjimmy

Mostly formatting. A little use of private APIs outside their own class.

tools/config/__init__.py

tools/toolchains/__init__.py

aashishc1988 · 2018-11-01T19:51:31Z

Changes added. @theotherjimmy @deepikabhavnani please review

bridadan

Quite a few questions, a few suggested changes, but nothing scary 😄 good work!

tools/config/__init__.py

tools/toolchains/__init__.py

aashishc1988 · 2018-11-01T22:44:19Z

@bridadan @theotherjimmy Made some more changes. Can you guys review again?

theotherjimmy

This is looking better. Further comments below.

I think that get_all_rom_regions and get_all_ram_regions look very similar. Could we de-deplicate this into a single helper function that takes in the differences?

tools/config/__init__.py

aashishc1988 · 2018-11-02T19:56:27Z

Did some refactoring. Combined get_all_rom/ram regions function into one. Created a new function that gives the list of all available region for ram/rom, since this information is used at couple of places, it was better to put it one place than to duplicate.

tools/config/__init__.py

bridadan

Definitely looking better! Just echoing some of @theotherjimmy's comments.

tools/toolchains/__init__.py

tools/config/__init__.py

deepikabhavnani · 2018-11-05T21:44:32Z

@aashishc1988 - ~~I tried this PR for K64F to fetch RAM/ROM sizes and it looks RAM size is incorrect.~~

Steps to reproduce: mbed compile -m K64F -t GCC_ARM -v

As per the build log, defines passed are:
-DMBED_ROM_START=0x0 -DMBED_ROM_SIZE=0x100000 -DMBED_RAM_START=0x20000000 -**DMBED_RAM_SIZE=0x30000** -DMBED_RAM1_START=0x1fff0000 -DMBED_RAM1_SIZE=0x10000
As per CMSIS pack : "SRAM_UPPER": {"start": "0x20000000", "size": "0x020000"}}
Looks like DMBED_RAM_SIZE - is addition of SRAM_Upper and SRAM_lower sizes

Verified it again in /tools/arm_pack_manager/index.json and SRAM size is 0x30000 for MK64FN1M0xxx12

aashishc1988 · 2018-11-06T17:27:33Z

Adding in the suggested changes.

bridadan

Nice work!

0xc0170 · 2018-11-07T08:10:42Z

@deepikabhavnani Waiting for your review (you have one PR depending on this one), please review

deepikabhavnani

Please squash the commits and add commit message describing the change

deepikabhavnani · 2018-11-07T14:57:24Z

@0xc0170 - I have tested this PR with dependent PR for single target, so it should be good to go after appropriate commit messages are added

@cmonr - PR adds few defines to build steps, which can be verified by #8661. Can we add both of them in single CI test as 8661 is essentially a test for this PR

mbed-ci · 2018-11-16T23:53:55Z

Test run: FAILED

Summary: 4 of 7 test jobs failed
Build number : 25
Build artifacts
Build logs

Failed test jobs:

jenkins-ci/mbed-os-ci_build-ARM
jenkins-ci/mbed-os-ci_mbed2-build-GCC_ARM
jenkins-ci/mbed-os-ci_mbed2-build-ARM
jenkins-ci/mbed-os-ci_mbed2-build-IAR

deepikabhavnani · 2018-11-17T02:33:08Z

NRF error looks related to UART, seems I have seen this before and was resolved?

[1542407234.13][CONN][RXD] :144::FAIL: Expected 'passed' Was 'pased'

deepikabhavnani · 2018-11-17T02:35:57Z

Not able to find failures in jenkins-ci, logs and results say success.. :-(

cmonr · 2018-11-17T02:41:40Z

Not able to find failures in jenkins-ci, logs and results say success.. :-(

NRF issue. Will restart in a bit.

Retriggered the pr-head job. Looks odd.

0xc0170 · 2018-11-19T14:08:52Z

Info: This PR has been re-bundled into a new rollup PR (#8800).

No further work is needed here, as once that PR is merged, this PR will also be closed and marked as merged.
If any more commits are made in this PR, this PR will remain open and have to go through CI on its own.

cmonr · 2018-11-22T02:03:06Z

Restarting CI.

mbed-ci · 2018-11-22T06:15:46Z

Test run: SUCCESS

Summary: 4 of 4 test jobs passed
Build number : 27
Build artifacts
Build logs

RAM/ROM sizes in tools were updated to report entire device size, and in M2351 they were used earlier to report secure/non-secure partition size. M2351 files are updated to take full RAM/ROM device size and derive secure and non-secure partition size based on that.

### Description PR ARMmbed#8607 will cause problems for the NRF52832 and the NRF52840 in the online compiler starting with 5.10.2. This PR prevents this problem by using a toggle in `targets.json` to enable these new defines for every target except for the NRF52832 and NRF52840. ### Pull request type [x] Fix [ ] Refactor [ ] Target update [ ] Functionality change [ ] Docs update [ ] Test update [ ] Breaking change

### Description PR #8607 will cause problems for the NRF52832 and the NRF52840 in the online compiler starting with 5.10.2. This PR prevents this problem by using a toggle in `targets.json` to enable these new defines for every target except for the NRF52832 and NRF52840. ### Pull request type [x] Fix [ ] Refactor [ ] Target update [ ] Functionality change [ ] Docs update [ ] Test update [ ] Breaking change

- Adjust memory for SoftDevice - Enable PRIO=5 for interrupt priority check - Change NRF_SD_BLE_API_VERSION to 6 - Add handle and buffer for advertising and scanning - Remove guard for phy update - Change scatter files and mbed_lib.json for PR ARMmbed#8607

cmonr requested review from theotherjimmy and deepikabhavnani November 1, 2018 01:32

cmonr added the needs: review label Nov 1, 2018

theotherjimmy suggested changes Nov 1, 2018

View reviewed changes

deepikabhavnani requested a review from bridadan November 1, 2018 20:13

bridadan suggested changes Nov 1, 2018

View reviewed changes

theotherjimmy suggested changes Nov 2, 2018

View reviewed changes

aashishc1988 commented Nov 2, 2018

View reviewed changes

tools/config/__init__.py Outdated Show resolved Hide resolved

0xc0170 added needs: work and removed needs: review labels Nov 5, 2018

theotherjimmy suggested changes Nov 5, 2018

View reviewed changes

bridadan suggested changes Nov 5, 2018

View reviewed changes

tools/toolchains/__init__.py Outdated Show resolved Hide resolved

tools/toolchains/__init__.py Outdated Show resolved Hide resolved

tools/config/__init__.py Outdated Show resolved Hide resolved

tools/config/__init__.py Outdated Show resolved Hide resolved

theotherjimmy approved these changes Nov 6, 2018

View reviewed changes

deepikabhavnani mentioned this pull request Nov 6, 2018

Add RAM/ROM memory statistics to system stats structure #8661

Closed

4 tasks

bridadan approved these changes Nov 6, 2018

View reviewed changes

0xc0170 added needs: CI needs: review and removed needs: work needs: CI labels Nov 7, 2018

0xc0170 approved these changes Nov 7, 2018

View reviewed changes

deepikabhavnani suggested changes Nov 7, 2018

View reviewed changes

aashishc1988 force-pushed the ram_rom_fetch branch from 631949a to 7d6435e Compare November 7, 2018 16:12

cmonr added the needs: work label Nov 17, 2018

cmonr added rollup PR and removed needs: work labels Nov 17, 2018

NirSonnenschein added the risk: G label Nov 18, 2018

0xc0170 mentioned this pull request Nov 19, 2018

Rollup PR: Rerun falsely-failed PRs for 5.11-RC1 #8800

Closed

theotherjimmy mentioned this pull request Nov 19, 2018

Migrate old memap file handling into toolchains #8779

Merged

This was referenced Nov 19, 2018

Add RAM/ROM stats to the application ARMmbed/mbed-os-example-sys-info#12

Merged

Add RAM/ROM info ARMmbed/mbed-os-5-docs#842

Merged

0xc0170 added ready for merge and removed needs: CI ready for merge labels Nov 22, 2018

0xc0170 merged commit 5b42e28 into ARMmbed:master Nov 22, 2018

0xc0170 removed the rollup PR label Nov 22, 2018

cmonr removed the risk: G label Dec 11, 2018

theotherjimmy mentioned this pull request Dec 12, 2018

Enable stats reporting with a flag in targets.json #9072

Merged

TacoGrandeTX mentioned this pull request Dec 18, 2018

NRF52 SDK15 update #9019

Merged

Fetch ram/rom start/size #8607

Fetch ram/rom start/size #8607

Uh oh!

Conversation

aashishc1988 commented Oct 31, 2018 • edited by cmonr Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Pull request type

Uh oh!

aashishc1988 commented Oct 31, 2018

Uh oh!

theotherjimmy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aashishc1988 commented Nov 1, 2018

Uh oh!

bridadan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aashishc1988 commented Nov 1, 2018

Uh oh!

theotherjimmy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aashishc1988 commented Nov 2, 2018

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bridadan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

deepikabhavnani commented Nov 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aashishc1988 commented Nov 6, 2018

Uh oh!

bridadan left a comment

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Nov 7, 2018

Uh oh!

deepikabhavnani left a comment

Choose a reason for hiding this comment

Uh oh!

deepikabhavnani commented Nov 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

aashishc1988 commented Oct 31, 2018 •

edited by cmonr

Loading

deepikabhavnani commented Nov 5, 2018 •

edited

Loading

deepikabhavnani commented Nov 7, 2018 •

edited

Loading