-
Notifications
You must be signed in to change notification settings - Fork 3k
Rollup PR: Rerun falsely-failed PRs for 5.11-RC1 #8800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…s with multiple segments, as required by NRF52 bootloader.
* Remove max_app_addr logic from tools/config/__init__.py as it was not working properly with some of the .hex files.
NRF Softdevice hex file can be in chunks. Make sure we account for the space where the bootloader resides by including all the chunks within the end of rom marker. This will clearly mark out the initial bootloader region.
RAM/ROM memory data of target is required for statistics and linker files, goal here is to fetch maximum 4 RAM/ROM regions from CMSIS pack and make them available for C/C++/Linker flags as defines
Update the padding sequence so that the gaps are padded after all the regions are merged. This avoids overwriting active regions and serializes the process.
Rename loop varibles for better readability and formatting changes.
Patch from the end of the first segment. Remove unused code.
1. Adding SRAM in available ram 2. If the target doesn't exist in cmsis but targets.json, handle accordingly and raise apt exceptions where needed. 3. If no sram is provided, raise exception
Internal RAM / ROM memory size and start address of target can be fetched using `mbed_stats_sys_get()` API.
1, add "extern "C" {} " to "wifi_ind.h" for being called by CPP files.
…need a try/catch when we call it. Moved "bootloader_not_supported" check to where it was and handle that exception at only one place. Removed ram/rom size info for realtek from targets.json. THe info we have is not correct. was Not handling config exceptions from regions and ram_regions property adding rom-ram info for REALTEK_RTL8195AM
…into dev_rollup
/morph build |
Build : SUCCESSBuild number : 3678 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 3280 |
Test : FAILUREBuild number : 3448 |
/morph test |
Test : FAILUREBuild number : 3449 |
/morph test |
Test : FAILUREBuild number : 3450 |
On the plus side, the failures for the last run seem to have passed on their own, sans network issues. Restarting. |
Test : FAILUREBuild number : 3452 |
Welp, I can say I tried. Of all the ways this could have failed, it had to be this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The NRF PR will not completely go in, since Russ added more commits, but it will be good to have what's here in for now.
(Fingers Crossed) |
Test : FAILUREBuild number : 3455 |
I fetched the binaries, run 2 failed test multiple times, can't reproduce it on K64F /morph test |
Test : FAILUREBuild number : 3456 |
Should we replace the K64F in CI? |
Not sure if that helps but worth trying (@cmonr was looking at this option) , see #8807 (comment). it fails for 3 kinetis devices. |
/morph build |
1 similar comment
/morph build |
Build : SUCCESSBuild number : 3700 Triggering tests/morph test |
Test : FAILUREBuild number : 3469 |
Exporter Build : FAILUREBuild number : 3297 |
Test run: SUCCESSSummary: 4 of 4 test jobs passed |
First PR with new CI! Ignoring old CI jobs:
|
Closing since will regenerate with more PRs, and some other PRs need to be removed. |
Description
List of PR:
Pull request type