-
Notifications
You must be signed in to change notification settings - Fork 3k
Adding Murata WSM-BL241 as new target #8756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@ashok-rao I think LED2 should be marked as NC. |
Thanks @cmonr , done in the latest commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small change request
// The 'features' section in 'target.json' is now used to create the device's hardware preprocessor switches. | ||
// Check the 'features' section of the target description in 'targets.json' for more details. | ||
/* mbed Microcontroller Library | ||
* Copyright (c) 2006-2013 ARM Limited |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you fix the year (2018
) ? And also add SPDX identifier right below
/*
* Copyright (c) 2018, Arm Limited and affiliates.
* SPDX-License-Identifier: Apache-2.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @0xc0170 .. Done in latest commit.
/morph build |
Build : SUCCESSBuild number : 3658 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 3265 |
Info: This PR has been re-bundled into a new rollup PR (#8800). No further work is needed here, as once that PR is merged, this PR will also be closed and marked as merged. |
Starting CI |
Test run: SUCCESSSummary: 4 of 4 test jobs passed |
Description
Adding Murata WSM-BL241 as a new MTB target.
Pull request type
This is a new MTB target based on nRF52832.
Greentea logs attached below. There is only 1 LED brought out on the board. Does the other 2 LED's need to be defined (& ==NC) for greentea / CI ? @0xc0170 @cmonr can you please let me know?
BL241_GT_Log_ARMCC_Pass.txt
BL241_GT_Log_GCC_Pass.txt
BL241_GT_Log_IAR_Pass.txt