Skip to content

Adding Murata WSM-BL241 as new target #8756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 22, 2018
Merged

Adding Murata WSM-BL241 as new target #8756

merged 5 commits into from
Nov 22, 2018

Conversation

ashok-rao
Copy link
Contributor

Description

Adding Murata WSM-BL241 as a new MTB target.

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

This is a new MTB target based on nRF52832.

Greentea logs attached below. There is only 1 LED brought out on the board. Does the other 2 LED's need to be defined (& ==NC) for greentea / CI ? @0xc0170 @cmonr can you please let me know?

BL241_GT_Log_ARMCC_Pass.txt
BL241_GT_Log_GCC_Pass.txt
BL241_GT_Log_IAR_Pass.txt

@cmonr
Copy link
Contributor

cmonr commented Nov 15, 2018

@ashok-rao I think LED2 should be marked as NC.
IIrc, there's a test that blinks two leds, not just one, and we've had a new target fail testing because it didn't have that definiition 😄

@ashok-rao
Copy link
Contributor Author

Thanks @cmonr , done in the latest commit.

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change request

// The 'features' section in 'target.json' is now used to create the device's hardware preprocessor switches.
// Check the 'features' section of the target description in 'targets.json' for more details.
/* mbed Microcontroller Library
* Copyright (c) 2006-2013 ARM Limited
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the year (2018) ? And also add SPDX identifier right below

/*
 * Copyright (c) 2018, Arm Limited and affiliates.
 * SPDX-License-Identifier: Apache-2.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @0xc0170 .. Done in latest commit.

@cmonr
Copy link
Contributor

cmonr commented Nov 17, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Nov 17, 2018

Build : SUCCESS

Build number : 3658
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8756/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Nov 17, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 19, 2018

Info: This PR has been re-bundled into a new rollup PR (#8800).

No further work is needed here, as once that PR is merged, this PR will also be closed and marked as merged.
If any more commits are made in this PR, this PR will remain open and have to go through CI on its own.

@cmonr
Copy link
Contributor

cmonr commented Nov 22, 2018

Starting CI

@mbed-ci
Copy link

mbed-ci commented Nov 22, 2018

Test run: SUCCESS

Summary: 4 of 4 test jobs passed
Build number : 3
Build artifacts
Build logs

@0xc0170 0xc0170 merged commit 7995e8b into ARMmbed:master Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants