Greentea netsocket and network tests improvements #8780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@VeijoPesonen @SeppoTakalo , please review. |
Test run: FAILEDSummary: 6 of 6 test jobs failed Failed test jobs:
|
michalpasztamobica
force-pushed
the
greentea_improvements
branch
from
fd4907a to
fe740c6
Compare
VeijoPesonen
approved these changes
Nov 19, 2018
Added smarter rounding of times in recv_timeout and increased the delta by one, to allow "off-by-one" errors. Reverted commit 88eea6a, reducing TESTS_TIMEOUT back to 480. Introduced a 100ms timeout for waiting on asynchronous DNS resolution. Improved error handling on disconnects.
michalpasztamobica
force-pushed
the
greentea_improvements
branch
from
fe740c6 to
e53ee63
Compare
|
@mtomczykmobica told me that ESP8266 was the chip that was causing most trouble and indeed - the rounding is only sufficient in the first recv, but the other one always failed: So I followed Veijo's advice and increased the delta time to allow "off-by-one" errors. |
|
@SeppoTakalo Please review |
SeppoTakalo
approved these changes
Nov 19, 2018
Merged
|
Info: This PR has been re-bundled into a new rollup PR (#8838 ). No further work is needed here, as once that PR is merged, this PR will also be closed and marked as merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added smarter rounding of times in recv_timeout.
@VeijoPesonen , this is instead of just allowing an "off by one" error. Following @mtomczykmobica remark I checked that using milliseconds causes a dummy rounding of the real times:
So we thought it might be better to start with proper rounding and if that is not enough, we can introduce the "off by one" tolerance.
Reverted commit 88eea6a, reducing TESTS_TIMEOUT back to 480.
Introduced a 100ms timeout for waiting on asynchronous DNS resolution. (@VeijoPesonen , I checked that the DNS resolution takes up to 30 ms on my network, so I added some extra buffer beyond the 20 ms which you originally suggested.)
Improved error handling on disconnects.
Pull request type