Rollup v2 for 5.11rc1 #8838
Merged
Rollup v2 for 5.11rc1 #8838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1, add "extern "C" {} " to "wifi_ind.h" for being called by CPP files.
Added smarter rounding of times in recv_timeout and increased the delta by one, to allow "off-by-one" errors. Reverted commit 88eea6a, reducing TESTS_TIMEOUT back to 480. Introduced a 100ms timeout for waiting on asynchronous DNS resolution. Improved error handling on disconnects.
Updated cellular debug trace prints: - Removed unnecessary prints. - Tracing more in DEBUG level. - Read/write bytes not printed on big packets. - Signal quality (RSSI) traced to log network problems. - Dismissed AT data is traced. - Modem type and firmware version are traced. Network registration returns NotRegistered instead of StatusNotAvailable, because that's not in 3GPP TS 27.007.
Updated Doxygen, removed the only one call of the deprecated constructor from the tests.
…cket DTLSSocketWrapper is equivalent of TLSSocketWrapper but uses datagram mode and timers for handling Mbed TLS timeouts. Non-blocking connections were not working earlier, now fixed for both secure socket modes.
This is equivalent of TLSSocket class but for UDP and DTLS.
This also includes their Datagram counterparts: DTLSSocket and DTLSSocketWrapper. Coverage missing for timer-related functionality, but this would require more advanced stub development. The extra (d)tls_test_config.h is necessary for successful compilation without HW support for the mbedtls features in unittests. I reused the mbedtls stub found in features/nanostack/coap-service/test/coap-service/unittest/stub/mbedtls_stub.c and amended it slightly with a few missing functions.
Also, let DTLSSocket to be a friend of InternetSocket so it can do the name resolution from its _stack. + Some whitespace fixes
This is dependency to X509_CRT_PARSE but just to make sure that also the 'mbedtls_pk_context' structure is not used if that flag is not enabled.
Missing $ for after_success, same fix as previously done for PR code changes
- Fix handling of duplicate blockwise ACK's
CoAP data buffer was not added into duplication info store when creating response for blockwise request.
This leads to case where whole bootstrap flow just timeouts if received any duplicate messages during blockwise operation.
Fixes error: IOTCLT-3188 - UDP connection fails for lost ACK sending
- Remove error trace when building reset message without options
This makes it possible to build the reset message without allocating option or getting error message.
This was referenced Nov 22, 2018
|
CI restarted |
Test run: SUCCESSSummary: 4 of 4 test jobs passed |
|
We are investigating failures @ARMmbed/mbed-os-test ^^ |
|
Restarting exporter + cloud client test |
|
client test failure is valid - #8788 will need to be removed. I'll rework this rollup |
|
Reworked rollup, removed one offender, restarting CI now |
|
Waiting for exporters, once they complete this is ready |
Test run: SUCCESSSummary: 4 of 4 test jobs passed |
NirSonnenschein
approved these changes
Nov 24, 2018
There was a problem hiding this comment.
@0xc0170 , The rollup looks ok to me. the only thing that really caught my eye was a very magic number sequence in the cellular changes:
if (rssi == 99) {
rssi = 0;
} else {
rssi = -113 + 2 * rssi;
}
maybe this code makes perfect sense if you understand the cellular stack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
List of PR:
Pull request type