Skip to content

Deprecate TCP/UDPSocket open-calling constructors #8794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2018

Conversation

michalpasztamobica
Copy link
Contributor

Description

Updated Doxygen, removed the only one call of the deprecated constructor from the tests.

Pull request type

[ ] Fix
[x] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@michalpasztamobica
Copy link
Contributor Author

@SeppoTakalo , please review :)

@0xc0170 0xc0170 requested a review from a team November 19, 2018 11:10
@0xc0170 0xc0170 requested a review from a team November 19, 2018 11:11
Updated Doxygen, removed the only one call of the deprecated constructor from the tests.
@0xc0170
Copy link
Contributor

0xc0170 commented Nov 20, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Nov 20, 2018

Build : FAILURE

Build number : 3685
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8794/

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 20, 2018

Restarting, the logs indicate there was an error.

/morph build

@mbed-ci
Copy link

mbed-ci commented Nov 20, 2018

Build : SUCCESS

Build number : 3690
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8794/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Nov 20, 2018

@mbed-ci
Copy link

mbed-ci commented Nov 20, 2018

@michalpasztamobica
Copy link
Contributor Author

The failures seem unrelated to my changes and in general not connected to networking modules.
@0xc0170 , could this be some issue with the CI?

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 21, 2018

Yes, we had some issues. We'll take this to another rollup

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 22, 2018

Info: This PR has been re-bundled into a new rollup PR (#8838 ).

No further work is needed here, as once that PR is merged, this PR will also be closed and marked as merged.
If any more commits are made in this PR, this PR will remain open and have to go through CI on its own.

@0xc0170 0xc0170 merged commit 42940fa into ARMmbed:master Nov 24, 2018
@0xc0170 0xc0170 removed the needs: CI label Nov 24, 2018
@cmonr cmonr removed the rollup PR label Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants