-
Notifications
You must be signed in to change notification settings - Fork 3k
Deprecate TCP/UDPSocket open-calling constructors #8794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate TCP/UDPSocket open-calling constructors #8794
Conversation
@SeppoTakalo , please review :) |
Updated Doxygen, removed the only one call of the deprecated constructor from the tests.
640b9be
to
42940fa
Compare
/morph build |
Build : FAILUREBuild number : 3685 |
Restarting, the logs indicate there was an error. /morph build |
Build : SUCCESSBuild number : 3690 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 3291 |
Test : FAILUREBuild number : 3464 |
The failures seem unrelated to my changes and in general not connected to networking modules. |
Yes, we had some issues. We'll take this to another rollup |
Info: This PR has been re-bundled into a new rollup PR (#8838 ). No further work is needed here, as once that PR is merged, this PR will also be closed and marked as merged. |
Description
Updated Doxygen, removed the only one call of the deprecated constructor from the tests.
Pull request type