Skip to content

Update mbed-coap to version 4.7.2 #8837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 24, 2018
Merged

Update mbed-coap to version 4.7.2 #8837

merged 1 commit into from
Nov 24, 2018

Conversation

anttiylitokola
Copy link
Contributor

Description

  • Fix handling of duplicate blockwise ACK's
    CoAP data buffer was not added into duplication info store when creating response for blockwise request.
    This leads to case where whole bootstrap flow just timeouts if received any duplicate messages during blockwise operation.
    Fixes error: IOTCLT-3188 - UDP connection fails for lost ACK sending

  • Remove error trace when building reset message without options
    This makes it possible to build the reset message without allocating option or getting error message.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Update mbed-coap to version 4.7.2
8d341ae 
 - Fix handling of duplicate blockwise ACK's
    CoAP data buffer was not added into duplication info store when creating response for blockwise request.
    This leads to case where whole bootstrap flow just timeouts if received any duplicate messages during blockwise operation.
    Fixes error: IOTCLT-3188 - UDP connection fails for lost ACK sending

 - Remove error trace when building reset message without options
    This makes it possible to build the reset message without allocating option or getting error message.
@anttiylitokola
Copy link
Contributor Author

@TeroJaasko, please review.

@anttiylitokola
Copy link
Contributor Author

@0xc0170 Can we get this into next Mbed OS patch release?
This will fix critical registration issue with NB-IoT devices.

TeroJaasko
TeroJaasko approved these changes Nov 22, 2018
View reviewed changes
Copy link
Contributor

@TeroJaasko TeroJaasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 22, 2018

@0xc0170 Can we get this into next Mbed OS patch release?

The next release is 5.11.0, will be in

@bulislaw
Copy link
Member

What's the status? needs ci, review? ready to merge?

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 22, 2018

Waiting for CI now

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 22, 2018

CI was triggered

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 22, 2018

@mbed-os-test Please review, similar dynamic python error

@mbed-ci
Copy link

mbed-ci commented Nov 23, 2018

Test run: SUCCESS

Summary: 4 of 4 test jobs passed
Build number : 1
Build artifacts
Build logs

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 23, 2018 •
edited
Loading

dynamic-memory-usage will be restarted once the python script bug is fixed

I restarted exporters

@0xc0170 0xc0170 mentioned this pull request Nov 23, 2018
Merged
@0xc0170
Copy link
Contributor

0xc0170 commented Nov 23, 2018

Info: This PR has been re-bundled into a new rollup PR (#8838 ).

No further work is needed here, as once that PR is merged, this PR will also be closed and marked as merged.
If any more commits are made in this PR, this PR will remain open and have to go through CI on its own.

@0xc0170 0xc0170 merged commit 8d341ae into ARMmbed:master Nov 24, 2018
@0xc0170 0xc0170 removed the needs: CI label Nov 24, 2018
@cmonr cmonr removed the rollup PR label Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@TeroJaasko TeroJaasko TeroJaasko approved these changes

Assignees
No one assigned
Labels
priority: high release-version: 5.11.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@anttiylitokola @0xc0170 @bulislaw @mbed-ci @TeroJaasko @cmonr @adbridge