Fix unsigned packing bug in merge_regions #8544

[kaidokert]

Description

There is a randomly occuring bug at the merge_regions build stage which throws depending on computed CRC32 value. If 32-bit ( instead of 31-bit ) value is calculated, merge fails as follows:

Merging Regions
  Filling region bootloader with /opt/m/mbed/compiletest/cloud-2.0/mbed-os/features/FEATURE_BOOTLOADER/targets/TARGET_STM/TARGET_STM32F4/TARGET_STM32F439xI/TARGET_MODULE_UBLOX_ODIN_W2/TARGET_UBLOX_EVK_ODIN_W2/mbed-bootloader-sotp-v3_4_0.bin
  Padding region bootloader with 0x684 bytes
Traceback (most recent call last):
  File "/opt/m/mbed/compiletest/cloud-2.0/mbed-os/tools/make.py", line 293, in <module>
    ignore=options.ignore
  File "/opt/m/mbed/compiletest/cloud-2.0/mbed-os/tools/build_api.py", line 552, in build_project
    merge_region_list(region_list, res, notify)
  File "/opt/m/mbed/compiletest/cloud-2.0/mbed-os/tools/build_api.py", line 427, in merge_region_list
    _fill_header(region_list, region).tofile(header_filename, format='hex')
  File "/opt/m/mbed/compiletest/cloud-2.0/mbed-os/tools/build_api.py", line 397, in _fill_header
    header.puts(start, struct.pack(fmt, zlib.crc32(ih.tobinarray())))
struct.error: 'l' format requires -2147483648 <= number <= 2147483647

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

[theotherjimmy]

Perfect fix!

[0xc0170]

Info: This PR has been re-bundled into a new rollup PR (#8838 ).

No further work is needed here, as once that PR is merged, this PR will also be closed and marked as merged.
If any more commits are made in this PR, this PR will remain open and have to go through CI on its own.

[0xc0170]

This PR fails to build for client example.

Traceback (most recent call last):

  File "/builds/ws/mbed-os-ci_cloud-client-test/mbed-cloud-client-example/mbed-os/tools/make.py", line 71, in wrapped_build_project

    src_dir, build_dir, mcu, *args, **kwargs

  File "/builds/ws/mbed-os-ci_cloud-client-test/mbed-cloud-client-example/mbed-os/tools/build_api.py", line 549, in build_project

    merge_region_list(region_list, res, notify)

  File "/builds/ws/mbed-os-ci_cloud-client-test/mbed-cloud-client-example/mbed-os/tools/build_api.py", line 422, in merge_region_list

    _fill_header(region_list, region).tofile(header_filename, format='hex')

  File "/builds/ws/mbed-os-ci_cloud-client-test/mbed-cloud-client-example/mbed-os/tools/build_api.py", line 392, in _fill_header

    header.puts(start, struct.pack(fmt, zlib.crc32(ih.tobinarray())))

error: integer out of range for 'L' format code

@ARMmbed/mbed-os-tools Please review

[cmonr]

Starting CI, just to make sure something odd didn't happen with the Rollup PR.

[mbed-ci]

Test run: SUCCESS

Summary: 4 of 4 test jobs passed
Build number : 1
Build artifacts
Build logs

[0xc0170]

I reviewed build jobs, they look fine. However not certain why we had the previous build failure in the rollup. I set this to 5.11.1 (if this should be in 5.11.0, please shout now) as we can have this on master for some time to test

[0xc0170]

I reviewed build jobs, they look fine. However not certain why we had the previous build failure in the rollup. I set this to 5.11.1 (if this should be in 5.11.0, please shout now) as we can have this on master for some time to test

Still this is valid, this PR is going to be reverted soon

@kaidokert Please review the failure I shared 7 days ago

[0xc0170]

Removed release label (not yet released, will be reverted just on master)

[0xc0170]

PR was reverted. Please review failures, as this was fixing another issue, would be good to have the fix

[cmonr]

@kaidokert Fyi ^^^