Skip to content

Cellular: Fix ATHandler URC processing #8790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 26, 2018
Merged

Cellular: Fix ATHandler URC processing #8790

merged 1 commit into from
Nov 26, 2018

Conversation

AriParkkila
Copy link

Description

Two closely related fixes to ATHandler:

  • AT timeout for URC processing callback increased to one second
  • URC processing flag to be set in RX event handler and cleared in process URC function

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@AriParkkila
Copy link
Author

@mirelachirica @jarvte please review

mirelachirica
mirelachirica reviewed Nov 19, 2018
View reviewed changes
kjbracey
kjbracey reviewed Nov 19, 2018
View reviewed changes
mirelachirica
mirelachirica reviewed Nov 19, 2018
View reviewed changes
@0xc0170
Copy link
Contributor

0xc0170 commented Nov 19, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Nov 19, 2018

Build : SUCCESS

Build number : 3670
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8790/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Nov 19, 2018

Exporter Build : SUCCESS

Build number : 3273
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8790/

@mbed-ci
Copy link

mbed-ci commented Nov 19, 2018

Test : FAILURE

Build number : 3443
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8790/3443

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 19, 2018

Aborted the test job, will restart later or as part of the rollup

@0xc0170 0xc0170 mentioned this pull request Nov 22, 2018
Merged
@0xc0170
Copy link
Contributor

0xc0170 commented Nov 24, 2018

Please rebase to resolve conflict

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 26, 2018

CI started

@mbed-ci
Copy link

mbed-ci commented Nov 26, 2018

Test run: SUCCESS

Summary: 4 of 4 test jobs passed
Build number : 1
Build artifacts
Build logs

@0xc0170 0xc0170 merged commit 3c0d6f0 into ARMmbed:master Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@kjbracey kjbracey kjbracey approved these changes

@AnttiKauppila AnttiKauppila AnttiKauppila approved these changes

@mirelachirica mirelachirica mirelachirica approved these changes

@jarvte jarvte jarvte approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@AriParkkila @0xc0170 @mbed-ci @kjbracey @AnttiKauppila @mirelachirica @jarvte