Update the Watchdog & Reset_reason host test scripts #8846
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 22, 2018 20:43
Move the calls to get_config_item() to the setup() method. The config is not available in the initializer yet.
Change the config parameter used as a delay before sending the sync packet after the device reset in watchdog and reset_reason tests. Use 'forced_reset_timeout' instead of 'program_cycle_s'.
0xc0170
approved these changes
Nov 23, 2018
donatieng
approved these changes
Nov 23, 2018
|
This one needs to land for 8801 to pass ? Or it's just cosmetic update? |
|
Sounds good to me 👍 |
Test run: SUCCESSSummary: 3 of 3 test jobs passed |
|
As this is ready, I'll merge it as we are waiting for reviews in 8801 (I am reviewing now). |
0xc0170
added
ready for merge
release-version: feature branch
and removed
ready for merge
release-version: 5.11.0-rc1
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the host test scripts used by Watchdog and Reset_reason HAL tests to use
forced_reset_timeoutconfig parameter instead ofprogram_cycle_s. This is based on PR #8309, which explains such change refering to https://github.com/ARMmbed/htrun/blob/1c570ec77d8c5673dae55dc790302d86d712c36b/mbed_host_tests/__init__.py#L132-L144Pull request type