-
Notifications
You must be signed in to change notification settings - Fork 3k
STM32L4: fix trng clock setting #8867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I can test on Nucleo-476 kit and a 475 custom board (runs the disco475iot01A target but is a custom board with a usb micro connector on usb signals PA10, PA11). |
This will be done in the system_clock.c file instead.
5c93419
to
08f9e80
Compare
I have updated this PR and only removed the TRNG clock setting. Tests are on-going on my side on all STM32L4 devices. If there are ok then it will be not needed to change the system_clock.c files... |
Tested on NUCLEO_L476RG board: |
Tested on custom DISCO_L475VG_IOT01A board: |
Thanks for the reports. On my side the TRNG tests are also PASS:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ST CI OK
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
@bcostm We are currently investigating a test failure with L4 device and tls. From the logs, it seems like entropy is broken. Reviewing the changes between good and bad state, this PR was flagged. We will provide more details once we test reverting this one. This is the commit range good and bad state (78d6018..fce4dc6) |
OK, I'll open a revert for review (this is currently only on master as 5.11.1 label here, not yet released). |
Description
Remove the TRNG clock setting for STM32L4 devices in the trng_api.c file to solve the conflict with USB clock setting.
Fix #8864
Pull request type