-
Notifications
You must be signed in to change notification settings - Fork 3k
Revert "STM32L4: fix trng clock setting" #9029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
||
/*Select PLLQ output as RNG clock source */ | ||
PeriphClkInitStruct.PeriphClockSelection = RCC_PERIPHCLK_RNG; | ||
PeriphClkInitStruct.RngClockSelection = RCC_RNGCLKSOURCE_PLL; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PeriphClkInitStruct.RngClockSelection = RCC_RNGCLKSOURCE_MSI;
Will resolve the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeromecoutant I tried this, but it will produce the same error as if the original fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, clock configuration is different for MTB_ADV_WISE_1570 than for NUCLEO_L486RG.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As previously was mentioned in original PR, should this adv wise target have own system clock config for this RNG selection?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you check my commit in https://github.com/jeromecoutant/mbed/tree/PR_L4TRNG ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeromecoutant that works for me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeromecoutant new PR and we close this revert?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirm reverting this fix enables tls&esfs to work again (require trng) on MTB_ADV_WISE_1570 (STM32L486)
@0xc0170, thank you for your changes. |
I set this to rc3 to keep track of this one (new PR might be up soon). |
Internal issue MBEDOSTEST-377 |
This is being replaced with #8867 |
Reverts #8867
@ARMmbed/team-st-mcd As noted in the PR itself, CI started failing because of this commit. I noticed TRNG tests were run for two L4 targets they did not fail, I am not certain why (opening this revert as the last resort, we shall fix this rather). Please review
cc @juhoeskeli