Skip to content

Revert "STM32L4: fix trng clock setting" #9029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Dec 10, 2018

Reverts #8867

@ARMmbed/team-st-mcd As noted in the PR itself, CI started failing because of this commit. I noticed TRNG tests were run for two L4 targets they did not fail, I am not certain why (opening this revert as the last resort, we shall fix this rather). Please review

cc @juhoeskeli

@0xc0170 0xc0170 requested review from a team and juhoeskeli December 10, 2018 12:17

/*Select PLLQ output as RNG clock source */
PeriphClkInitStruct.PeriphClockSelection = RCC_PERIPHCLK_RNG;
PeriphClkInitStruct.RngClockSelection = RCC_RNGCLKSOURCE_PLL;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PeriphClkInitStruct.RngClockSelection = RCC_RNGCLKSOURCE_MSI;

Will resolve the issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeromecoutant I tried this, but it will produce the same error as if the original fix.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, clock configuration is different for MTB_ADV_WISE_1570 than for NUCLEO_L486RG.

Copy link
Contributor Author

@0xc0170 0xc0170 Dec 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As previously was mentioned in original PR, should this adv wise target have own system clock config for this RNG selection?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeromecoutant that works for me

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeromecoutant new PR and we close this revert?

Copy link
Contributor

@juhoeskeli juhoeskeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm reverting this fix enables tls&esfs to work again (require trng) on MTB_ADV_WISE_1570 (STM32L486)

@ciarmcom ciarmcom requested a review from a team December 10, 2018 14:00
@ciarmcom
Copy link
Member

@0xc0170, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor Author

0xc0170 commented Dec 10, 2018

I set this to rc3 to keep track of this one (new PR might be up soon).

@0xc0170
Copy link
Contributor Author

0xc0170 commented Dec 10, 2018

Internal issue MBEDOSTEST-377

@cmonr
Copy link
Contributor

cmonr commented Dec 10, 2018

This is being replaced with #8867

@cmonr cmonr closed this Dec 10, 2018
@jeromecoutant
Copy link
Collaborator

This is being replaced with #8867

No, this is being replaced with #9035 :-)

@cmonr cmonr deleted the revert-8867-fix_trng_clock_setting branch January 11, 2019 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants