Cellular: Remove sim interface #8891

jarvte · 2018-11-28T11:47:43Z

Removed CellularSIM interface. Moved methods to classes CellularDevice and CellularInformation.
SIM interface was removed to simplify cellular usage and methods better suite new classes.
Fixed bug in CellularStateMachine that state machine did not stop to register state if that was a target where to stop, this is in first commit. Was found while updating greentea tests for CellularDevice.

@AriParkkila please review

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[X] Breaking change

AnttiKauppila · 2018-11-29T06:49:31Z

features/cellular/framework/API/CellularInformation.h

@@ -61,6 +66,8 @@ class CellularInformation {
     *  @param buf      revision identification as zero terminated string
     *  @param buf_size max length of revision identification is 2048 characters
     *  @return         NSAPI_ERROR_OK on success
+     *                  NSAPI_ERROR_PARAMETER if buf is null
+     *                  NSAPI_ERROR_PARAMETER if buf is null


Good catch, will fix

AnttiKauppila · 2018-11-29T06:56:09Z

features/cellular/framework/device/CellularStateMachine.cpp

+    tr_debug("check_is_target_reached(): target state %s, _state: %s, _cb_data.error: %d, _event_id: %d,_is_retry: %d", get_state_string(_target_state), get_state_string(_state), _cb_data.error, _event_id, _is_retry);
+
+    if ((_target_state == _state && _cb_data.error == NSAPI_ERROR_OK && !_is_retry) || _event_id == STM_STOPPED) {
+        tr_debug("Target state reached: %s, _cb_data.error: %d, _event_id: %d", get_state_string(_target_state), _cb_data.error, _event_id);


This is almost same as above trace. And should this be tr_info rather than tr_debug?

I'll remove the later but I'll leave it as debug or it will pollute log.

AnttiKauppila

Remove the duplicate doxygen and this is good.

0xc0170 · 2018-11-29T09:00:14Z

Migration path - any ? Does a user need to do anything?

jarvte · 2018-11-29T09:51:09Z

Migration path - any ? Does a user need to do anything?

This is going to 5.12, I created a jira ticket about updating the documentation. There is some other changes coming to 5.12 so we can better support Long time support. We will update documentation after other changes are also done.
If user have used CellularContext and CellularDevice interfaces (preferred way) then no actions needed. If user have used CellularSIM interface in application then user have to use interface CellularDevice/CellularInformation depending what method was used.

jarvte · 2018-12-03T07:42:09Z

Failure not related to this pr

cmonr · 2018-12-03T17:20:40Z

That's unfortunate. The base branch will need a rebase due to #8944 fixing a new Travis CI issue.

jarvte · 2018-12-04T06:25:17Z

That's unfortunate. The base branch will need a rebase due to #8944 fixing a new Travis CI issue.

Yes, very unfortunate. Also unfortunate is that I don't have rights to do rebase for a base branch. Maybe someone with access rights could do it?

0xc0170 · 2018-12-04T08:57:57Z

feature-cellular-refactor rebased

0xc0170 · 2018-12-04T08:58:52Z

I restarted travis, however it might need a new commit (can you rebase your branch quickly?)

jarvte · 2018-12-04T09:02:04Z

I restarted travis, however it might need a new commit (can you rebase your branch quickly?)

done.

cmonr · 2018-12-04T20:04:24Z

CI started

mbed-ci · 2018-12-05T05:38:32Z

Test run: SUCCESS

Summary: 4 of 4 test jobs passed
Build number : 1
Build artifacts
Build logs

jarvte · 2018-12-05T05:48:50Z

Finally found the failed case. It was HAL test: qspi frequency setting test
Nothing to do with this PR.

After re-run greentea passed

0xc0170

761838fdf969c465ac6663a730dbd021defb40dc The commit message should be fixed - considering this is breaking change, lot of files changed. One liner as it is now is not sufficient.

Moved methods to classes CellularDevice and CellularInformation. SIM interface was removed to simplify cellular usage and methods better suite new classes. Updated greentea and unit tests.

jarvte · 2018-12-05T11:03:33Z

@0xc0170 updated commit message

cmonr · 2018-12-05T15:50:01Z

CI started

mbed-ci · 2018-12-05T18:36:47Z

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

jarvte force-pushed the remove_sim_interface branch from 68c9fb7 to f15dc0c Compare November 28, 2018 12:07

AriParkkila approved these changes Nov 28, 2018

View reviewed changes

0xc0170 requested a review from AnttiKauppila November 28, 2018 13:03

0xc0170 added needs: review BREAKING-CHANGE labels Nov 28, 2018

AnttiKauppila reviewed Nov 29, 2018

View reviewed changes

AnttiKauppila approved these changes Nov 29, 2018

View reviewed changes

jarvte force-pushed the remove_sim_interface branch from f15dc0c to 3e6cd2c Compare November 29, 2018 07:31

0xc0170 requested a review from a team November 29, 2018 09:00

jarvte changed the base branch from master to feature-cellular-refactor November 30, 2018 12:50

cmonr added the release-version: 5.12.0-rc1 label Nov 30, 2018

jarvte closed this Dec 3, 2018

jarvte deleted the remove_sim_interface branch December 3, 2018 07:00

studavekar removed the needs: review label Dec 3, 2018

jarvte restored the remove_sim_interface branch December 3, 2018 07:08

jarvte reopened this Dec 3, 2018

cmonr added the needs: review label Dec 3, 2018

cmonr added needs: work and removed needs: review labels Dec 4, 2018

0xc0170 added release-version: feature branch and removed release-version: 5.12.0-rc1 labels Dec 4, 2018

Cellular: Fixed CellularStateMachine to stop on all target states.

573b6ce

jarvte force-pushed the remove_sim_interface branch from 3e6cd2c to 761838f Compare December 4, 2018 09:01

cmonr added needs: CI and removed needs: work labels Dec 4, 2018

0xc0170 added ready for merge and removed needs: CI labels Dec 5, 2018

0xc0170 changed the title ~~Cellular: Removed sim interface~~ Cellular: Remove sim interface Dec 5, 2018

0xc0170 added needs: work and removed ready for merge labels Dec 5, 2018

0xc0170 requested changes Dec 5, 2018

View reviewed changes

Removed CellularSIM interface.

176067b

Moved methods to classes CellularDevice and CellularInformation. SIM interface was removed to simplify cellular usage and methods better suite new classes. Updated greentea and unit tests.

jarvte force-pushed the remove_sim_interface branch from 761838f to 176067b Compare December 5, 2018 11:01

0xc0170 approved these changes Dec 5, 2018

View reviewed changes

0xc0170 added needs: CI and removed needs: work labels Dec 5, 2018

cmonr merged commit f52c9e3 into ARMmbed:feature-cellular-refactor Dec 5, 2018

cmonr removed the needs: CI label Dec 5, 2018

jarvte deleted the remove_sim_interface branch December 10, 2018 06:18

Cellular: Remove sim interface #8891

Cellular: Remove sim interface #8891

Uh oh!

Conversation

jarvte commented Nov 28, 2018

Pull request type

Uh oh!

AnttiKauppila Nov 29, 2018

Choose a reason for hiding this comment

Uh oh!

jarvte Nov 29, 2018

Choose a reason for hiding this comment

Uh oh!

AnttiKauppila Nov 29, 2018

Choose a reason for hiding this comment

Uh oh!

jarvte Nov 29, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AnttiKauppila left a comment

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Nov 29, 2018

Uh oh!

jarvte commented Nov 29, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jarvte commented Dec 3, 2018

Uh oh!

cmonr commented Dec 3, 2018

Uh oh!

jarvte commented Dec 4, 2018

Uh oh!

0xc0170 commented Dec 4, 2018

Uh oh!

0xc0170 commented Dec 4, 2018

Uh oh!

jarvte commented Dec 4, 2018

Uh oh!

cmonr commented Dec 4, 2018

Uh oh!

mbed-ci commented Dec 5, 2018

Test run: SUCCESS

Uh oh!

jarvte commented Dec 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xc0170 left a comment

Choose a reason for hiding this comment

Uh oh!

jarvte commented Dec 5, 2018

Uh oh!

cmonr commented Dec 5, 2018

Uh oh!

mbed-ci commented Dec 5, 2018

Test run: SUCCESS

Uh oh!

Uh oh!

jarvte Nov 29, 2018 •

edited

Loading

jarvte commented Nov 29, 2018 •

edited

Loading

jarvte commented Dec 5, 2018 •

edited

Loading