Skip to content

Travis fix: rabbitmq key update (travis msg broker) #8944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 3, 2018
Merged

Travis fix: rabbitmq key update (travis msg broker) #8944

merged 2 commits into from
Dec 3, 2018

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Dec 3, 2018 •
edited
Loading

Description

Testing latest breakage in travis CI

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@0xc0170
Copy link
Contributor Author

0xc0170 commented Dec 3, 2018

This should address #8945

@0xc0170
travis: mangodb key update not needed anymore
13822a4
@0xc0170
travis: rabbitmq signature update
9b4be1b 
Fix comes from rabbitmq:

> On December 1st, 2018 (GMT) all repositories under the RabbitMQ account on PackageCloud
will be switched to use the new signing keys. RabbitMQ users who install packages
from PackageCloud must import the new signing keys before the migration.
The recommended way of doing that is by re-running PackageCloud setup
scripts (RabbitMQ, Erlang). Signing keys can be downloaded and imported directly
as well (RabbitMQ, Erlang). If the new keys are not imported, package installation
will start failing with a signature verification error.
@0xc0170 0xc0170 requested review from OPpuolitaival and a team December 3, 2018 10:33
@0xc0170
Copy link
Contributor Author

0xc0170 commented Dec 3, 2018

Rebased

  • Remove mango database fix, not needed anymore
  • Add rabbitmq key update (they changed it 2 days ago)

Latest run was green, expecting this one as well.

@0xc0170 0xc0170 changed the title Test travis Travis fix: rabbitmq key update (travis msg broker) Dec 3, 2018
OPpuolitaival
OPpuolitaival approved these changes Dec 3, 2018
View reviewed changes
Copy link
Contributor

@OPpuolitaival OPpuolitaival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@0xc0170
Copy link
Contributor Author

0xc0170 commented Dec 3, 2018

CI started

@0xc0170
Copy link
Contributor Author

0xc0170 commented Dec 3, 2018

continuous-integration/travis-ci/pr — The Travis CI build passed

Travis green 💯

@mbed-ci
Copy link

mbed-ci commented Dec 3, 2018

Test run: SUCCESS

Summary: 4 of 4 test jobs passed
Build number : 1
Build artifacts
Build logs

@0xc0170
Copy link
Contributor Author

0xc0170 commented Dec 3, 2018

@ARMmbed/mbed-os-maintainers Waiting for your final approval

adbridge
adbridge approved these changes Dec 3, 2018
View reviewed changes
Copy link
Contributor

@adbridge adbridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT LGTM

@0xc0170 0xc0170 merged commit f8e1116 into ARMmbed:master Dec 3, 2018
@0xc0170
Copy link
Contributor Author

0xc0170 commented Dec 3, 2018

As this might affect the next release (rc2), I labeled it as such

cmonr
cmonr reviewed Dec 3, 2018
View reviewed changes
.travis.yml
# Fix for "The following signatures were invalid: KEYEXPIRED 1515625755" failed". See https://github.com/travis-ci/travis-ci/issues/9037
- sudo apt-key adv --keyserver hkp://keyserver.ubuntu.com:80 --recv 0C49F3730359A14518585931BC711F9BA15703C6
# import the new keys for rabbitmq (fix for https://github.com/ARMmbed/mbed-os/issues/8945)
- curl -s https://packagecloud.io/install/repositories/rabbitmq/rabbitmq-server/script.deb.sh | sudo bash
Copy link
Contributor

@cmonr cmonr Dec 3, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😥

Blindly downloading a shell script and piping into bash should never be considered a fix.

Unfortunately, I don't know of any other way to fix this aside from Travis CI fixing the issue on their side. This at least allows us to progress PRs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This follows https://packagecloud.io/rabbitmq/rabbitmq-server/install . Let's rewrite this or report to travis to actually update it on their side

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving to: #8950

@cmonr cmonr mentioned this pull request Dec 3, 2018
Merged
@0xc0170 0xc0170 deleted the dev_test_travis branch December 4, 2018 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr left review comments

@OPpuolitaival OPpuolitaival OPpuolitaival approved these changes

@adbridge adbridge adbridge approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.0-rc2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@0xc0170 @mbed-ci @cmonr @OPpuolitaival @adbridge