-
Notifications
You must be signed in to change notification settings - Fork 3k
Rapid-IoT: Add support for the KW41Z side of the platform #9053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rapid-IoT: Add support for the KW41Z side of the platform #9053
Conversation
@mmahadevan108, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also test results (I've noticed one binary file here - serialpass, what is it?)
@@ -0,0 +1,136 @@ | |||
/* mbed Microcontroller Library | |||
* Copyright (c) 2006-2013 ARM Limited |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add SPDX specifier to the new files please?
SPDX-License-Identifier: Apache-2.0
(files in platform for instance contain it already)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also fix the year (new files should have 2018 in this case)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, copyright on the new files updated to the right year and added the Apache identifier
5a02e56
to
a40c423
Compare
Where are the test results, can you share? |
Test results below: |
@0xc0170 - the serial passthrough binary is required to run the tests on the KW41Z inside Rapid IoT. Since there is no direct serial connection from DAPLink to the KW41Z, the serial passes through the K64F inside Rapid IoT. So you have to load the K64F with the serial passthrough before running tests on KW41Z. |
@mmahadevan108 That description is really useful. Would you mind including a portion of it in the commit message, so that others may have a shot at finding the issues without knowing how to find this PR? |
Add support for the KW41Z side of the RapidIoT platform. This requires the latest DAPLink binary to be programmed on the RapidIoT platform, binary can be downloaded from the below link: https://armmbed.github.io/DAPLink/ Also, the KW41Z side on RapidIoT does not have a serial port connected to the Debug terminal. Therefore a SerialPassThrough program should be flashed and running on the K64F side of RapidIoT platform for the mbed tests to pass. Signed-off-by: Mahesh Mahadevan <[email protected]>
a40c423
to
3d8d65b
Compare
Commit description updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @mmahadevan108
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Not sure, but looks like it CI was started twice... |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Description
Add support for the KW41Z side of the RapidIoT platform. This requires the latest DAPLink binary to be programmed on the RapidIoT platform, binary can be downloaded from the below link:
https://armmbed.github.io/DAPLink/
Also, the KW41Z side on RapidIoT does not have a serial port connected to the Debug terminal. Therefore a SerialPassThrough program should be flashed and running on the K64F side of RapidIoT platform for the mbed tests to pass. Attached is a binary for this PassThrough program.
Pull request type
RapidIoT_SerialPass.zip