Skip to content

Rapid-IoT: Add support for the KW41Z side of the platform #9053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 18, 2018

Conversation

mmahadevan108
Copy link
Contributor

Description

Add support for the KW41Z side of the RapidIoT platform. This requires the latest DAPLink binary to be programmed on the RapidIoT platform, binary can be downloaded from the below link:
https://armmbed.github.io/DAPLink/

Also, the KW41Z side on RapidIoT does not have a serial port connected to the Debug terminal. Therefore a SerialPassThrough program should be flashed and running on the K64F side of RapidIoT platform for the mbed tests to pass. Attached is a binary for this PassThrough program.

Pull request type

[ ] Fix
[ ] Refactor
[X] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

RapidIoT_SerialPass.zip

@mmahadevan108
Copy link
Contributor Author

cc @maclobdell @0xc0170 @cmonr

@ciarmcom
Copy link
Member

@mmahadevan108, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team December 11, 2018 14:00
@0xc0170 0xc0170 requested a review from maclobdell December 11, 2018 14:06
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also test results (I've noticed one binary file here - serialpass, what is it?)

@@ -0,0 +1,136 @@
/* mbed Microcontroller Library
* Copyright (c) 2006-2013 ARM Limited
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add SPDX specifier to the new files please?

SPDX-License-Identifier: Apache-2.0 (files in platform for instance contain it already)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also fix the year (new files should have 2018 in this case)

Copy link
Contributor Author

@mmahadevan108 mmahadevan108 Dec 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, copyright on the new files updated to the right year and added the Apache identifier

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 12, 2018

Also test results (I've noticed one binary file here - serialpass, what is it?)

Where are the test results, can you share?

@mmahadevan108
Copy link
Contributor Author

mmahadevan108 commented Dec 12, 2018

Test results below:
GCC_ARM_RapidIoT_KW41.txt
ARM_RapidIoT_KW41.txt
IAR_RapidIoT_KW41.txt

@maclobdell
Copy link
Contributor

@0xc0170 - the serial passthrough binary is required to run the tests on the KW41Z inside Rapid IoT. Since there is no direct serial connection from DAPLink to the KW41Z, the serial passes through the K64F inside Rapid IoT. So you have to load the K64F with the serial passthrough before running tests on KW41Z.

@cmonr
Copy link
Contributor

cmonr commented Dec 14, 2018

@mmahadevan108 That description is really useful. Would you mind including a portion of it in the commit message, so that others may have a shot at finding the issues without knowing how to find this PR?

Add support for the KW41Z side of the RapidIoT platform. This requires the latest
DAPLink binary to be programmed on the RapidIoT platform, binary can be downloaded
from the below link:
https://armmbed.github.io/DAPLink/

Also, the KW41Z side on RapidIoT does not have a serial port connected to the Debug
terminal. Therefore a SerialPassThrough program should be flashed and running on the
K64F side of RapidIoT platform for the mbed tests to pass.

Signed-off-by: Mahesh Mahadevan <[email protected]>
@mmahadevan108 mmahadevan108 force-pushed the Add-Support-RapidIoT-KW41Z branch from a40c423 to 3d8d65b Compare December 14, 2018 12:38
@mmahadevan108
Copy link
Contributor Author

Commit description updated.

Copy link
Contributor

@ashok-rao ashok-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @mmahadevan108

@cmonr
Copy link
Contributor

cmonr commented Dec 17, 2018

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 17, 2018

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@cmonr
Copy link
Contributor

cmonr commented Dec 17, 2018

Not sure, but looks like it CI was started twice...
@0xc0170

@mbed-ci
Copy link

mbed-ci commented Dec 18, 2018

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 merged commit eda1952 into ARMmbed:master Dec 18, 2018
@mmahadevan108 mmahadevan108 deleted the Add-Support-RapidIoT-KW41Z branch January 2, 2019 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants