Skip to content

STM32 QSPI update #9089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Dec 14, 2018
Merged

STM32 QSPI update #9089

merged 11 commits into from
Dec 14, 2018

Conversation

jeromecoutant
Copy link
Collaborator

Description

Few patches around QSPI feature within STM32:

  • DISCO_F746NG is now enabled
  • DISCO_F769NI is now enabled
  • DISCO_F469NI is now enabled
  • DISCO_L496AG is now enabled
  • QSPI pins have been removed for boards that don't have embeded QSPI
  • dual bank QSPI pins have been removed
  • frequency setting is corrected

QSPIF component tests and QSPI feature tests have been executed.

This fixes #8870

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@jeromecoutant
Copy link
Collaborator Author

@offirko @screamerbg

@ciarmcom ciarmcom requested review from a team December 13, 2018 12:00
@ciarmcom
Copy link
Member

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-maintainers @ARMmbed/mbed-os-hal @ARMmbed/mbed-os-test @ARMmbed/mbed-os-storage please review.

offirko
offirko approved these changes Dec 13, 2018
View reviewed changes
Copy link
Contributor

@offirko offirko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@offirko
Copy link
Contributor

offirko commented Dec 13, 2018

I've enabled QSPIF for DISCO_L496AG and ran QSPIF_BD tests successfully on my board.

cmonr
cmonr approved these changes Dec 14, 2018
View reviewed changes
Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@cmonr
Copy link
Contributor

cmonr commented Dec 14, 2018

Change is highly specific to ST targets. Progressing.

@cmonr
Copy link
Contributor

cmonr commented Dec 14, 2018

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 14, 2018

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr merged commit 64e7e46 into ARMmbed:master Dec 14, 2018
@jeromecoutant jeromecoutant deleted the DEV_QSPI_TEST branch December 14, 2018 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@offirko offirko offirko approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: QSPI support on DISCO_F769NI
6 participants
@jeromecoutant @ciarmcom @offirko @cmonr @mbed-ci @0xc0170