Renesas : Add USB Device feature #9165

TomoYamanaka · 2018-12-20T04:47:07Z

Description

I implemented USB Device feature for Renesas mbed boards(GR-PEACH and GR-LYCHEE).
The Greentea test of USB Device(Basic / Serial) results are here.
Test_PEACH_GCC.txt
Test_LYCHEE_GCC.txt

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

cmonr · 2018-12-20T04:52:10Z

@TomoYamanaka Would you be able to provide greentea test results for the USB tests?

TomoYamanaka · 2018-12-20T04:55:56Z

@cmonr

I attached two text files in the above description section. Please you let me know if you can't watch them.

cmonr · 2018-12-20T04:58:01Z

@TomoYamanaka Whoops, I did in fact miss those.

Would you happen to also have ARM and IAR results?

TomoYamanaka · 2018-12-20T05:41:40Z

@cmonr Sure. Please wait a bit.

TomoYamanaka · 2018-12-20T06:06:24Z

@cmonr
ARMCC and IAR test results are here.

[ARMCC]
Test_PEACH_ARM.txt
Test_LYCHEE_ARM.txt

[IAR]
Test_PEACH_IAR.txt
Test_LYCHEE_IAR.txt

0xc0170 · 2018-12-20T14:53:36Z

usb/device/targets/TARGET_RENESAS/TARGET_RZ_A1XX/USBEndpoints_RZ_A1.h

+* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
+* DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+*/


the license looks almost OK but as this is a new file, can you add apache 2.0 here, update the copyright and also fix the name, add SPDX identifier as well

I modified this file's header by commit 4c47084.

0xc0170 · 2018-12-20T14:54:09Z

usb/device/targets/TARGET_RENESAS/TARGET_RZ_A1XX/USBPhy_RZ_A1_Def.h

@@ -0,0 +1,681 @@
+


missing license header

I modified this file's header by commit 4c47084.

0xc0170 · 2018-12-20T14:54:42Z

usb/device/targets/TARGET_RENESAS/TARGET_RZ_A1XX/USBPhy_RZ_A1.cpp

@@ -0,0 +1,1506 @@
+/* mbed Microcontroller Library
+ * Copyright (c) 2018-2018 ARM Limited
+ *


Add SPDX identifier

I modified this file's header by commit 4c47084.

cmonr · 2018-12-20T18:04:45Z

usb/device/targets/TARGET_RENESAS/TARGET_RZ_A1XX/USBEndpoints_RZ_A1.h

@@ -0,0 +1,85 @@
+/* Copyright (c) 2010-2011 mbed.org, MIT License


@TomoYamanaka I'd br curious to hear about the history of this file since this header makes me think it's beein around for a while.

Sorry, this is new file. It seems that the information of the reference file has remained. I modified this file's header by commit 4c47084.

I implemented USB Device feature for Renesas mbed boards. The code referenced the following code as a starting point and is implemented it by inheritting USBPhy same as other boards. (mbed-os\features\unsupported\USBDevice\targets\TARGET_RENESAS)

Comments addressed. Please re-review.

cmonr · 2018-12-21T03:27:02Z

@0xc0170 Please re-review. Should be alright now.

cmonr · 2018-12-21T20:13:02Z

CI started

mbed-ci · 2018-12-21T23:51:16Z

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_greentea-test

NirSonnenschein · 2018-12-24T10:41:28Z

@TomoYamanaka
strange failures in tests, which may not be unrelated:
http://mbed-os-ci.s3-website-eu-west-1.amazonaws.com/?prefix=jenkins-ci/artifacts/9165/1/greentea-test/647/

tests which failed:
ARCH_PRO iar_arm / ARCH_PRO-IAR.tests-usb_device-serial.CDC USB reconnectARCH_PRO arm-none-eabi-gcc / ARCH_PRO-GCC_ARM.tests-usb_device-serial.CDC USB reconnectARCH_PRO armcc / ARCH_PRO-ARM.tests-usb_device-serial.CDC USB reconnectNUCLEO_F207ZG iar_arm / NUCLEO_F207ZG-IAR.tests-usb_device-serial.CDC USB reconnectNUCLEO_F207ZG armcc / NUCLEO_F207ZG-ARM.tests-usb_device-serial.CDC USB reconnectNUCLEO_F207ZG arm-none-eabi-gcc / NUCLEO_F207ZG-GCC_ARM.tests-usb_device-serial.CDC USB reconnectNUCLEO_F429ZI iar_arm / NUCLEO_F429ZI-IAR.tests-usb_device-serial.CDC USB reconnectNUCLEO_F429ZI armcc / NUCLEO_F429ZI-ARM.tests-usb_device-serial.CDC USB reconnectNUCLEO_F429ZI arm-none-eabi-gcc / NUCLEO_F429ZI-GCC_ARM.tests-usb_device-serial.CDC USB reconnectK64F iar_arm / K64F-IAR.tests-usb_device-serial.CDC USB reconnectK64F armcc / K64F-ARM.tests-usb_device-serial.CDC USB reconnectK64F arm-none-eabi-gcc / K64F-GCC_ARM.tests-usb_device-serial.CDC USB reconnect

cmonr · 2018-12-24T17:23:18Z

@c1728p9 Is it possible something came into this branch that's causing issues?

cmonr · 2018-12-28T05:52:03Z

Running CI on the feature branch. Will report bcak in the morning.

cmonr · 2018-12-28T20:40:13Z

Interesting. It looks like the base branch failed.

cmonr · 2018-12-28T20:44:44Z

Ooooh. Crap. It looks like the PR that added the tests was run on the old CI.

@studavekar @OPpuolitaival Do you know/remember what test runner differences exist between the old CI and the new one? Looking at this PR's failures (they're the same as the base branch), there's a bunch of socketio activity, but the test simply times out.

@TomoYamanaka On the plus side, this means that once we get this test issue sorted out, this PR should be easy to bring through since it seems to be fine.

studavekar · 2018-12-31T05:28:08Z

@cmonr none of us test should be running as defined in https://github.com/ARMmbed/mbed-os-ci/blob/master/mbed-os-jenkins/mbed-os-ci-greentea-test/Jenkinsfile.groovy#L54

0xc0170 · 2019-01-02T12:08:39Z

@cmonr none of us test should be running as defined in https://github.com/ARMmbed/mbed-os-ci/blob/master/mbed-os-jenkins/mbed-os-ci-greentea-test/Jenkinsfile.groovy#L54

@OPpuolitaival Can you review? Looks to me that this covers only some usb tests not serial one? Not certain what has changed on the feature branch but looks like this is CI config issue?

0xc0170 · 2019-01-03T13:42:51Z

Set as "needs: work", until we fix the config in the CI

OPpuolitaival · 2019-01-03T14:09:22Z

@cmonr @0xc0170 This is bigger issue in CI and it takes time to figure out how to make this testing happening in CI setup. Need to test manually for now

OPpuolitaival · 2019-01-03T14:18:15Z

I mean that this PR change need to be tested manually, CI is not testing it. The CI error root cause is most probably CI misconfiguration during the development. I did restart the test

cmonr · 2019-01-03T21:43:09Z

@OPpuolitaival For the time being, is there anything we can do from the GitHub side of things to progress this PR, or is this stuck waiting on a CI change?

OPpuolitaival · 2019-01-04T12:21:59Z

feature-hal-spec-usb-device branch do not pass the CI. That is the root cause. The results are visible in https://mbed-os.mbedcloudtesting.com/job/mbed-os-ci/job/feature-hal-spec-usb-device/ I need to find someone to discuss what is the best solution for that

OPpuolitaival · 2019-01-04T12:26:47Z

Started email thread with @studavekar and @c1728p9

OPpuolitaival · 2019-01-07T10:09:59Z

Fixed usb tests skip command:
"tests-usb_device-basic" => "tests-usb_device-*"
Commit in internal repository: https://github.com/ARMmbed/mbed-os-ci/commit/65b8762973a2fefa792f9f5a2b1faffb60d7f82c

Restarted tests also

cmonr added release-version: feature branch needs: review labels Dec 20, 2018

cmonr requested a review from c1728p9 December 20, 2018 04:51

0xc0170 previously requested changes Dec 20, 2018

View reviewed changes

cmonr added needs: work and removed needs: review labels Dec 20, 2018

cmonr reviewed Dec 20, 2018

View reviewed changes

Renesas : Implement USB Device feature

4c47084

I implemented USB Device feature for Renesas mbed boards. The code referenced the following code as a starting point and is implemented it by inheritting USBPhy same as other boards. (mbed-os\features\unsupported\USBDevice\targets\TARGET_RENESAS)

TomoYamanaka force-pushed the usb_device branch from 0a2270b to 4c47084 Compare December 21, 2018 02:02

cmonr approved these changes Dec 21, 2018

View reviewed changes

cmonr added needs: review and removed needs: work labels Dec 21, 2018

0xc0170 approved these changes Dec 21, 2018

View reviewed changes

cmonr added needs: CI and removed needs: review labels Dec 21, 2018

cmonr added parked and removed parked labels Jan 2, 2019

0xc0170 added needs: work and removed needs: CI labels Jan 3, 2019

cmonr added the parked label Jan 4, 2019

0xc0170 removed the parked label Jan 7, 2019

cmonr added ready for merge and removed needs: work labels Jan 9, 2019

cmonr merged commit 8b6fffb into ARMmbed:feature-hal-spec-usb-device Jan 9, 2019

cmonr removed the ready for merge label Jan 9, 2019

TomoYamanaka deleted the usb_device branch January 10, 2019 00:37

		@@ -0,0 +1,85 @@
		/* Copyright (c) 2010-2011 mbed.org, MIT License

Renesas : Add USB Device feature #9165

Renesas : Add USB Device feature #9165

Conversation

TomoYamanaka commented Dec 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Pull request type

Uh oh!

cmonr commented Dec 20, 2018

Uh oh!

TomoYamanaka commented Dec 20, 2018

Uh oh!

cmonr commented Dec 20, 2018

Uh oh!

TomoYamanaka commented Dec 20, 2018

Uh oh!

TomoYamanaka commented Dec 20, 2018

Uh oh!

0xc0170 Dec 20, 2018

Choose a reason for hiding this comment

Uh oh!

TomoYamanaka Dec 21, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xc0170 Dec 20, 2018

Choose a reason for hiding this comment

Uh oh!

TomoYamanaka Dec 21, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xc0170 Dec 20, 2018

Choose a reason for hiding this comment

Uh oh!

TomoYamanaka Dec 21, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cmonr Dec 20, 2018

Choose a reason for hiding this comment

Uh oh!

TomoYamanaka Dec 21, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cmonr commented Dec 21, 2018

Uh oh!

cmonr commented Dec 21, 2018

Uh oh!

mbed-ci commented Dec 21, 2018

Test run: FAILED

Uh oh!

NirSonnenschein commented Dec 24, 2018 • edited by cmonr Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmonr commented Dec 24, 2018

Uh oh!

cmonr commented Dec 28, 2018

Uh oh!

cmonr commented Dec 28, 2018

Uh oh!

cmonr commented Dec 28, 2018

Uh oh!

studavekar commented Dec 31, 2018

Uh oh!

0xc0170 commented Jan 2, 2019

Uh oh!

0xc0170 commented Jan 3, 2019

Uh oh!

OPpuolitaival commented Jan 3, 2019

Uh oh!

OPpuolitaival commented Jan 3, 2019

Uh oh!

cmonr commented Jan 3, 2019

Uh oh!

OPpuolitaival commented Jan 4, 2019

Uh oh!

OPpuolitaival commented Jan 4, 2019

Uh oh!

TomoYamanaka commented Dec 20, 2018 •

edited

Loading

TomoYamanaka Dec 21, 2018 •

edited

Loading

TomoYamanaka Dec 21, 2018 •

edited

Loading

TomoYamanaka Dec 21, 2018 •

edited

Loading

TomoYamanaka Dec 21, 2018 •

edited

Loading

NirSonnenschein commented Dec 24, 2018 •

edited by cmonr

Loading