Kvstore tests api change to run on K64F only #9244
Conversation
|
@theamirocohen, thank you for your changes. |
Why only on one target ? |
The modified tests check the functionality of the various KVStore APIs. Most of them run in memory (over the Heap block device). Thus they should produce the same results for each device they run on (providing it has enough RAM). In other words, these tests check the KVStore functionality without actually testing the board's storage. The one test that does run on the actual board's storage is |
|
The real and wide test for different boards is the test for the static API. Until now, this test was also not executed in many targets because the default configuration was for external memory, and not many boards have the right components in targets.json. |
|
I would like to have @ARMmbed/mbed-os-test review. This feels like there should be unit tests rather? Testing only on one target does not feel right (why only one and why that one will be questions we get) |
|
|
@theamirocohen as already asked, can you add to the commit message a reason for limiting to just one target and why it was chosen that specific target? |
|
The only blocking thing here is the request above and @ARMmbed/mbed-os-storage team approval |
Change KVStore API tests to run only on K64F, these tests check the KVStore functionality without actually testing the board's storage, Thus they should produce the same results for each device they run on. K64F was selected for no special technical reason but only because of it being available and convenient to use.
theamirocohen
force-pushed
the
kvstore_tests_api
branch
from
31821c4 to
9a5841a
Compare
The commits were merged and the commit message was changed |
|
What about removing features/storage/kvstore/mbed_lib.json file, |
Good idea. @theamirocohen Can you take care of it? It's indeed not required now as the tests only run on K64F. |
In addition, use the NOT_SUPPORTED directive to skip the tests.
|
Removed KVStore's mbed_lib.json file. |
Which patches? |
|
CI started |
|
Relaunching Travis CI. Not sure why, but results didn't propigate... |
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
|
@ARMmbed/mbed-os-maintainers - Seems like it failed again to propagate: |
|
Test restarted |
|
I restarted also travis (it's not yet appearing to be pending here) |
|
Reopening this PR to get travis reenabled (does not report back anything but it's green) |
|
Travis green 💯 |
|
All green |
Change KVStore API tests to run only on K64F, these tests check the KVStore functionality without actually testing the board's storage, Thus they should produce the same results for each device they run on.
We don't see a point loading the CI with these tests if they all produce the same result regardless of the board.
The one test that does run on the actual board's storage is static_tests, which wasn't changed.
K64F was selected for no special technical reason but only because of it being available and convenient to use.