-
Notifications
You must be signed in to change notification settings - Fork 3k
KVSTORE: disable small RAM ST targets #9253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I recall there was PR addressing these small targets but can't find it. @davidsaada Please review |
@jeromecoutant, thank you for your changes. |
Well, there isn't one, but I guess you can treat #9244 as such: It enables almost all KVStore tests on K64F only, whaile the remaining test (static test) will not run on any target that has no storage component enabled. So - current PR, however harmless, is not really required (assuming we approve #9244. |
I don't understand this #9244 ... This should have a "do not merge" label as it is valid only for 1 target ? |
I don't have a problem accepting this PR, just noted it would become redundant once #9244 is accepted. One thing that can be misleading - the changes you made on the config file only affect tests, not the enablement of the whole feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, there isn't one, but I guess you can treat #9244 as such: It enables almost all KVStore tests on K64F only, whaile the remaining test (static test) will not run on any target that has no storage component enabled. So - current PR, however harmless, is not really required (assuming we approve #9244.
If we go with 9244 (most probably will go in), we do not need this one, do we @jeromecoutant ? |
Why KVSTORE tests be executable only with K64F ??? |
@davidsaada I just had a thought. If this test is only testing the functionality of the software layer sans hardware, why not turn it into a unit test? |
Issue will be fixed by #9244 |
Description
Seems that KVSTORE should be disabled for small RAM targets.
Pull request type