Skip to content

KVSTORE: disable small RAM ST targets #9253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

jeromecoutant
Copy link
Collaborator

Description

Seems that KVSTORE should be disabled for small RAM targets.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 4, 2019

I recall there was PR addressing these small targets but can't find it. @davidsaada Please review

@ciarmcom ciarmcom requested review from a team January 4, 2019 12:00
@ciarmcom
Copy link
Member

ciarmcom commented Jan 4, 2019

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-storage @ARMmbed/mbed-os-maintainers please review.

@davidsaada
Copy link
Contributor

I recall there was PR addressing these small targets but can't find it. @davidsaada Please review

Well, there isn't one, but I guess you can treat #9244 as such: It enables almost all KVStore tests on K64F only, whaile the remaining test (static test) will not run on any target that has no storage component enabled. So - current PR, however harmless, is not really required (assuming we approve #9244.

@jeromecoutant
Copy link
Collaborator Author

I don't understand this #9244 ... This should have a "do not merge" label as it is valid only for 1 target ?
So I think it will be faster to accept this one.

@davidsaada
Copy link
Contributor

I don't understand this #9244 ... This should have a "do not merge" label as it is valid only for 1 target ?
So I think it will be faster to accept this one.

I don't have a problem accepting this PR, just noted it would become redundant once #9244 is accepted. One thing that can be misleading - the changes you made on the config file only affect tests, not the enablement of the whole feature.

Copy link
Contributor

@davidsaada davidsaada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, there isn't one, but I guess you can treat #9244 as such: It enables almost all KVStore tests on K64F only, whaile the remaining test (static test) will not run on any target that has no storage component enabled. So - current PR, however harmless, is not really required (assuming we approve #9244.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 4, 2019

If we go with 9244 (most probably will go in), we do not need this one, do we @jeromecoutant ?

@jeromecoutant
Copy link
Collaborator Author

Why KVSTORE tests be executable only with K64F ???

@cmonr
Copy link
Contributor

cmonr commented Jan 4, 2019

@davidsaada I just had a thought.

If this test is only testing the functionality of the software layer sans hardware, why not turn it into a unit test?

@davidsaada
Copy link
Contributor

@cmonr This should probably be discussed in #9244, but regardless - KVStore relies on many other features: drivers, file systems, block devices, mbedtls and many more. It would better to have its tests triggered (even on a single device) following any change in these features.

@jeromecoutant
Copy link
Collaborator Author

Issue will be fixed by #9244

@jeromecoutant jeromecoutant deleted the PR_KVSTORE branch January 9, 2019 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants