SocketAddress doxygen cleanup #9300
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@melwee01 please review |
melwee01
approved these changes
Jan 9, 2019
0xc0170
approved these changes
Jan 9, 2019
|
CI started |
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
|
@ARMmbed/mbed-os-test Please review the test failure (CI script related) |
|
CI started |
|
I don't think so. Since doxygen changes occur within source files, I think it's the right thing (for now) to test the source file. |
|
My bad on restarting all of CI :/ |
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
|
We will restart tests soon, once another 2 PR get in for 5.11.2 . Failure here is CI hw related |
melwee01
approved these changes
Jan 10, 2019
jarlamsa
force-pushed
the
socket_address_doxy
branch
from
96f923c to
8cbc2b9
Compare
|
@SeppoTakalo please review |
|
This PR will be brought in as part of #9328 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minor changes and cleaning.
Pull request type
Reviewers