Skip to content

Doxygen fixes for IP networking area #9328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Jan 22, 2019
Merged

Doxygen fixes for IP networking area #9328

merged 25 commits into from
Jan 22, 2019

Conversation

SeppoTakalo
Copy link
Contributor

@SeppoTakalo SeppoTakalo commented Jan 10, 2019 •
edited
Loading

Description

Doxygen fixes and clarifications for IP networking area.
We have also combined some updates from Ari regarding Cellular area.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[X] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@KariHaapalehto @AriParkkila @kjbracey-arm

@ciarmcom
Copy link
Member

@SeppoTakalo, thank you for your changes.
@AriParkkila @kjbracey-arm @KariHaapalehto @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

This was referenced Jan 10, 2019
Closed
Closed
melwee01
melwee01 suggested changes Jan 10, 2019
View reviewed changes
@melwee01
Copy link
Contributor

I'm working on these right now, so you don't need to worry about applying my comments unless there are content, not editing, issues.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 11, 2019

Can you review travis failures, some are pointing to the undefined parameters or astyle reporting changes in the license alignment or similar?

SeppoTakalo
SeppoTakalo commented Jan 11, 2019
View reviewed changes
@SeppoTakalo
Copy link
Contributor Author

Needs work label can be removed. This is reviewed and review findings are fixed.
Can be merged in.

No API changes, so can also be published in patch release.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 15, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 15, 2019

Test run: FAILED

Summary: 1 of 7 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM

@SeppoTakalo
Copy link
Contributor Author

Rebased and fixed the missing copyright header.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 21, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 21, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_dynamic-memory-usage

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 22, 2019

dynamic-memory-usage restarted

@0xc0170 0xc0170 merged commit 31579fe into ARMmbed:master Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr left review comments

@0xc0170 0xc0170 0xc0170 approved these changes

@melwee01 melwee01 melwee01 approved these changes

@AriParkkila AriParkkila AriParkkila approved these changes

@michalpasztamobica michalpasztamobica michalpasztamobica approved these changes

@KariHaapalehto KariHaapalehto Awaiting requested review from KariHaapalehto

@kjbracey kjbracey Awaiting requested review from kjbracey

Assignees
No one assigned
Labels
release-version: 5.11.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@SeppoTakalo @ciarmcom @melwee01 @0xc0170 @mbed-ci @cmonr @AriParkkila @michalpasztamobica @adbridge @KariHaapalehto