Skip to content

WifiInterface doxygen cleanup #9301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

WifiInterface doxygen cleanup #9301

wants to merge 1 commit into from

Conversation

jarlamsa
Copy link
Contributor

@jarlamsa jarlamsa commented Jan 9, 2019

Description

Minor changes and clarification

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[x] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@jarlamsa
Copy link
Contributor Author

jarlamsa commented Jan 9, 2019

@melwee01 please review

melwee01
melwee01 approved these changes Jan 9, 2019
View reviewed changes
Copy link
Contributor

@melwee01 melwee01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nitpicks.

@jarlamsa jarlamsa force-pushed the wifi_interface_doxy branch from 13c1920 to 0fcdaba Compare January 9, 2019 11:04
@0xc0170
Copy link
Contributor

0xc0170 commented Jan 9, 2019

@melwee01 Let us know when this is ready for CI

@melwee01
Copy link
Contributor

melwee01 commented Jan 9, 2019

Style nitpick that we generally don't use future tense, but we do allow it for conditionals (if-phrases). So I'm good with this as-is, except that one sentence that I feel is unclear.

@jarlamsa jarlamsa force-pushed the wifi_interface_doxy branch from 0fcdaba to 04305e5 Compare January 9, 2019 13:16
@melwee01
Copy link
Contributor

melwee01 commented Jan 9, 2019

This is ready as far as I'm concerned.

@cmonr
Copy link
Contributor

cmonr commented Jan 9, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 9, 2019

Test run: FAILED

Summary: 1 of 7 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR

@cmonr
Copy link
Contributor

cmonr commented Jan 9, 2019

Dang it. Restarting CI.

IAR build is backed up, not stalled.

@mbed-ci
Copy link

mbed-ci commented Jan 10, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 10, 2019

Test will be restarted bit later (device failure above not related here) , there are 2 important PR to get through CI now

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 10, 2019

We will restart tests soon, once another 2 PR get in for 5.11.2 . Failure here is CI hw related

@jarlamsa jarlamsa force-pushed the wifi_interface_doxy branch from e79786d to 90e08ca Compare January 10, 2019 13:01
@jarlamsa
Copy link
Contributor Author

@SeppoTakalo please review

@jarlamsa
Copy link
Contributor Author

This PR will be brought in as a part of #9328

@jarlamsa jarlamsa closed this Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melwee01 melwee01 melwee01 approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jarlamsa @0xc0170 @melwee01 @cmonr @mbed-ci @studavekar