Minor Doxygen fixes for all file system classes #9305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davidsaada, thank you for your changes. |
GuyWi
reviewed
Jan 9, 2019
GuyWi
reviewed
Jan 9, 2019
davidsaada
force-pushed
the
david_littlefs_fatfs_doxy_fix
branch
from
23be723 to
f52a6e8
Compare
|
@davidsaada How does this PR interact with #9308? |
We'll need to merge them. This one originally modified the Doxy for LittleFS and FAT FS, but then I noticed that they were all copied from FileSystem base class, so I propagated the changes there as well. #9308 made other changes on the base class separately. |
davidsaada
force-pushed
the
david_littlefs_fatfs_doxy_fix
branch
from
e27eb92 to
1059c07
Compare
|
Took all relevant changes from #9308 and squashed all commits. |
- Remove Doxygen generation on protected functions - Minor description fixes
davidsaada
force-pushed
the
david_littlefs_fatfs_doxy_fix
branch
from
1059c07 to
3c7924a
Compare
davidsaada
changed the title
cmonr
approved these changes
Jan 10, 2019
|
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
|
This is sitting on top of #8972 which is a major feature for 5.12 so this is being moved to 5.12 also. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes minor fixes for all file system classes: Base class, LittleFS and FATFS.
Pull request type
Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[x] Docs update
[ ] Test update
[ ] Breaking change