Skip to content

Minor Doxygen fixes for FileSystem #9308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Minor Doxygen fixes for FileSystem #9308

wants to merge 2 commits into from

Conversation

yossi2le
Copy link
Contributor

@yossi2le yossi2le commented Jan 9, 2019

Description

This PR includes minor fixes for the FileSystem interface.

  • Remove Doxygen generation on protected functions
  • Minor description fixes

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[x] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ciarmcom ciarmcom requested review from a team January 9, 2019 14:00
@ciarmcom
Copy link
Member

ciarmcom commented Jan 9, 2019

@yossi2le, thank you for your changes.
@ARMmbed/mbed-os-storage @ARMmbed/mbed-os-maintainers please review.

@cmonr
Copy link
Contributor

cmonr commented Jan 9, 2019

@GuyWi Why did you remove the "needs: review" label?

cmonr
cmonr suggested changes Jan 10, 2019
View reviewed changes
Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small nit since this is the time to do it

@cmonr cmonr mentioned this pull request Jan 10, 2019
Merged
@yossi2le
Copy link
Contributor Author

close because the changes PR #9305 has been merged with this one

@yossi2le yossi2le closed this Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yossi2le @ciarmcom @cmonr @studavekar @melwee01 @GuyWi