Skip to content

Revert "Warn with ARMC6 and not v8m" #9398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2019
Merged

Conversation

kjbracey
Copy link
Contributor

Description

A requested change from the toolchain guys, who are working on getting ARMC6 support online - the the misleading message "ARMC6 does not support ARM architecture v7" is winding them up.

Not clear we need any message at this point, at least on master. Maybe we will need something more specific about targets later, once we can pin down restrictions.

This reverts commit 3f68411.

Marked it as a "docs update", as it doesn't change the build result, just what the build prints. That probably doesn't make any sense.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[X] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@theotherjimmy

Copy link
Contributor

@theotherjimmy theotherjimmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good to me.

@kjbracey
Copy link
Contributor Author

I think they would also quite like this backported to a 5.11.y so they can get a clean-looking build prior to official Mbed OS 5.12 release. I leave that open to debate - maybe with sufficient disclaimers elsewhere...

@0xc0170 0xc0170 requested a review from bulislaw January 16, 2019 15:40
@0xc0170
Copy link
Contributor

0xc0170 commented Jan 16, 2019

I think they would also quite like this backported to a 5.11.y so they can get a clean-looking build prior to official Mbed OS 5.12 release. I leave that open to debate - maybe with sufficient disclaimers elsewhere...

Fine with me

cc @bulislaw

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 16, 2019

If we can rebase, will fix travis

@cmonr
Copy link
Contributor

cmonr commented Jan 17, 2019

NOTE: This PR has now been rebased.

If this was made in error, feel free to force-push your local branch to restore the PR.

@cmonr
Copy link
Contributor

cmonr commented Jan 17, 2019

Marked for 5.12 for now. If ARMc6 support slips, past that RC, we'll need to re-enable the message.

I'm sure you've informed them that the main reason around the message is to help set user expectations as to what compilers are actively supported.

@cmonr
Copy link
Contributor

cmonr commented Jan 17, 2019

SIGH

travis-ci/doxy-spellcheck failure is caused by something slipping in whilst the PR that enabled the job was making it's way through testing.

mbed-os master is broken (https://travis-ci.org/ARMmbed/mbed-os/jobs/480700843) and needs a fix to progress this PR. Hold tight.

@cmonr
Copy link
Contributor

cmonr commented Jan 17, 2019

NOTE: This PR has now been rebased.

If this was made in error, feel free to force-push your local branch to restore the PR.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 18, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 18, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 2a7a326 into ARMmbed:master Jan 21, 2019
@kjbracey kjbracey deleted the no_armc6_warn branch January 23, 2019 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants