Py3 fixes and Travis CI enablement #9521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
January 28, 2019 12:59
It seems that initializing mock variables in an object isn't enough
Py3 tests were not running as a result
cmonr
commented
Jan 28, 2019
theotherjimmy
suggested changes
Jan 28, 2019
tools/config/__init__.py
Outdated
| @@ -1204,7 +1204,8 @@ def validate_config(self): | |||
| min = int(str(min), 0) if min is not None else None | |||
| max = int(str(max), 0) if max is not None else None | |||
|
|
|||
| if (value < min or (value > max if max is not None else False)): | |||
| if ((value < min if min is not None else False) or | |||
There was a problem hiding this comment.
Could this be written:
Suggested change
| if ((value < min if min is not None else False) or | |
| if ((min is not None and value < min) or |
tools/config/__init__.py
Outdated
| @@ -1204,7 +1204,8 @@ def validate_config(self): | |||
| min = int(str(min), 0) if min is not None else None | |||
| max = int(str(max), 0) if max is not None else None | |||
|
|
|||
| if (value < min or (value > max if max is not None else False)): | |||
| if ((value < min if min is not None else False) or | |||
| (value > max if max is not None else False)): | |||
There was a problem hiding this comment.
Suggested change
| (value > max if max is not None else False)): | |
| (max is not None and value > max)): |
added 2 commits
January 28, 2019 13:54
Other jobs will follow with other PR
theotherjimmy
approved these changes
Jan 28, 2019
0xc0170
approved these changes
Jan 29, 2019
Co-Authored-By: cmonr <[email protected]>
|
CI started |
Test run: SUCCESSSummary: 12 of 12 test jobs passed |
|
This PR seems to have broken building with Python 3 for the 5.11.4 release. This is causing errors in the Mbed CLI CI: https://circleci.com/gh/ARMmbed/mbed-cli/1319?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link |
|
(I'm working on adding a compile step after the pytests to make sure this kind of thing is hard to reproduce, but I'll be damned if I'm going to do it while relying on |
|
The fix in #9673 fixed it locally for me, and the CI test will be very welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Came across some issues when setting up a testing env for Windows Python build issues (https://travis-ci.org/cmonr/mbed-os/builds/485516791), so fixed them as I went along.
This PR only contains the Py3 fixes along with finally enabling Py3 tests in Travis CI.
A Travis CI refactor will followup once this is brought in.
Pull request type
Reviewers