Skip to content

NUCLEO_L073RZ Bootloader support #9792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 1, 2019
Merged

NUCLEO_L073RZ Bootloader support #9792

merged 2 commits into from
Mar 1, 2019

Conversation

sarahmarshy
Copy link
Contributor

@sarahmarshy sarahmarshy commented Feb 21, 2019 •
edited
Loading

Description

Add bootloader support for NUCLEO_L073RZ.

Depends on - #9791 and #9798

Pull request type

[ X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@jeromecoutant

@ciarmcom ciarmcom requested review from a team February 21, 2019 12:00
@ciarmcom
Copy link
Member

@sarahmarshy, thank you for your changes.
@ARMmbed/mbed-os-maintainers @ARMmbed/mbed-os-core please review.

@sarahmarshy sarahmarshy force-pushed the nucleo-gcc-bootloader branch from df79467 to f22fb51 Compare February 21, 2019 13:59
@jeromecoutant jeromecoutant mentioned this pull request Feb 21, 2019
Merged
@sarahmarshy sarahmarshy force-pushed the nucleo-gcc-bootloader branch from f22fb51 to 4d337a8 Compare February 21, 2019 15:37
@jeromecoutant
Copy link
Collaborator

Hi
I think you can remove the "do not merge" from title and from label,
and use only the preceding PR label ?

@sarahmarshy sarahmarshy force-pushed the nucleo-gcc-bootloader branch from 4d337a8 to 44bc123 Compare February 21, 2019 16:14
@sarahmarshy sarahmarshy changed the title DO NOT MERGE - NUCLEO_L073RZ Bootloader support for GCC NUCLEO_L073RZ Bootloader support for GCC Feb 21, 2019
@cmonr
Copy link
Contributor

cmonr commented Feb 21, 2019

@sarahmarshy Is the intention for this to come into 5.11.5 as well?

@sarahmarshy
Copy link
Contributor Author

@cmonr, I don't think it matters. It just needs to be on master at some point.

@cmonr
Copy link
Contributor

cmonr commented Feb 21, 2019

Kk. Checking since Code Freeze for 5.11.5 is today 😁

@sarahmarshy sarahmarshy changed the title NUCLEO_L073RZ Bootloader support for GCC NUCLEO_L073RZ Bootloader support Feb 21, 2019
jeromecoutant
jeromecoutant reviewed Feb 22, 2019
View reviewed changes
targets/TARGET_STM/TARGET_STM32L0/TARGET_NUCLEO_L073RZ/device/TOOLCHAIN_IAR/stm32l073xx.icf Outdated
define symbol __intvec_start__ = 0x08000000;
define symbol __region_ROM_start__ = 0x08000000;
define symbol __region_ROM_end__ = 0x0802FFFF;
#if !defined(MBED_APP_START)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that this line doesn't compile...

I could see from other targets something like:
if (!isdefinedsymbol(MBED_APP_START)) { define symbol MBED_APP_START = 0x08000000; }

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. I've updated it.

@sarahmarshy sarahmarshy force-pushed the nucleo-gcc-bootloader branch 2 times, most recently from 857af7c to 22abea3 Compare February 22, 2019 13:21
@sarahmarshy
Copy link
Contributor Author

@ARMmbed/mbed-os-maintainers the two preceding PRs were merged. Can that label be removed?

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 25, 2019

@ARMmbed/mbed-os-maintainers the two preceding PRs were merged. Can that label be removed?

Done, waiting for @jeromecoutant approval

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 25, 2019

CI started

@deepikabhavnani
Copy link

Changes in this will might clash with 2-region update #9571 (comment)

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 25, 2019

Changes in this will might clash with 2-region update #9571 (comment)

Good point, how to proceed? This is quite simple PR so can be easily rebased

@deepikabhavnani
Copy link

It will be good to rebase this PR on #9571 and update the linker files accordingly, as new sections are added.

@deepikabhavnani
Copy link

Also changes from #9766 should be picked

@mbed-ci
Copy link

mbed-ci commented Feb 25, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 removed the needs: CI label Feb 26, 2019
@cmonr
Copy link
Contributor

cmonr commented Feb 28, 2019

Marking this as needs: CI to retest post-IAR8 changes.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 28, 2019

CI restarted

@mbed-ci
Copy link

mbed-ci commented Feb 28, 2019

Test run: FAILED

Summary: 1 of 13 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 28, 2019

Ci will be restarted (iar8 exporter issue we will resolve separately).

@deepikabhavnani
Copy link

#9766 might need rebase after this is merged.

Exporter issue is not present in CI now, @cmonr - Was CI restarted on this? Shows all success

@cmonr
Copy link
Contributor

cmonr commented Feb 28, 2019 •
edited
Loading

@deepikabhavnani It was.

Am doing a local merge check before offically merging PRs.

Er, my mistake. Thought #9776 was RfM. You're right, this might cause a rebase to be needed.

@cmonr
Copy link
Contributor

cmonr commented Feb 28, 2019

Was CI restarted on this?

Yes, I think.

@cmonr cmonr merged commit 4b9d07a into ARMmbed:master Mar 1, 2019
@jeromecoutant jeromecoutant mentioned this pull request Mar 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@jeromecoutant jeromecoutant jeromecoutant approved these changes

@deepikabhavnani deepikabhavnani deepikabhavnani approved these changes

Assignees
No one assigned
Labels
release-version: 5.12.0-rc1 risk: A
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sarahmarshy @ciarmcom @jeromecoutant @cmonr @0xc0170 @deepikabhavnani @mbed-ci