Skip to content

Unify PSA code generators #9918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2019
Merged

Unify PSA code generators #9918

merged 1 commit into from
Mar 6, 2019

Conversation

orenc17
Copy link
Contributor

@orenc17 orenc17 commented Mar 3, 2019 •
edited by NirSonnenschein
Loading

Description

Create a unified launcher for PSA code generators to simplify usage and avoid future mistakes.
Adapt Travis-CI to use unified launcher

Targeting release 5.12 (PSA)

Pull request type

[ ] Fix
[X] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@mikisch81

Release Notes

mikisch81
mikisch81 approved these changes Mar 3, 2019
View reviewed changes
Copy link
Contributor

@mikisch81 mikisch81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ciarmcom ciarmcom requested a review from mikisch81 March 3, 2019 20:00
@ciarmcom
Copy link
Member

ciarmcom commented Mar 3, 2019

@orenc17, thank you for your changes.
@mikisch81 @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested review from a team March 3, 2019 20:00
@NirSonnenschein
Copy link
Contributor

starting CI (CI is free)

theotherjimmy
theotherjimmy approved these changes Mar 4, 2019
View reviewed changes
Copy link
Contributor

@theotherjimmy theotherjimmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that this new file is only to be used as a script.

@orenc17
Copy link
Contributor Author

orenc17 commented Mar 5, 2019

@ARMmbed/mbed-os-maintainers can we get this merged? review is done

cmonr
cmonr approved these changes Mar 5, 2019
View reviewed changes
Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh. That's one way to do it.

@cmonr
Copy link
Contributor

cmonr commented Mar 5, 2019

CI started

@ghost ghost added the PM_ACCEPTED label Mar 5, 2019
@mbed-ci
Copy link

mbed-ci commented Mar 6, 2019

Test run: FAILED

Summary: 1 of 13 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter

@cmonr
Copy link
Contributor

cmonr commented Mar 6, 2019

CI restarted.
Merge commit needs to use updated master

@mbed-ci
Copy link

mbed-ci commented Mar 6, 2019

Test run: FAILED

Summary: 1 of 13 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 6, 2019

Exporters failed in CI related issue, will investigate

cc @ARMmbed/mbed-os-test

@alekla01
Copy link
Contributor

alekla01 commented Mar 6, 2019

Restarted jenkins-ci/exporter

@alekla01
Copy link
Contributor

alekla01 commented Mar 6, 2019

Restarted exporters (license issue)

@0xc0170 0xc0170 merged commit f236125 into ARMmbed:master Mar 6, 2019
@orenc17 orenc17 mentioned this pull request Mar 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@theotherjimmy theotherjimmy theotherjimmy approved these changes

@mikisch81 mikisch81 mikisch81 approved these changes

@NirSonnenschein NirSonnenschein NirSonnenschein approved these changes

Assignees
No one assigned
Labels
release-version: 5.12.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@orenc17 @ciarmcom @NirSonnenschein @cmonr @mbed-ci @0xc0170 @alekla01 @theotherjimmy @mikisch81