Skip to content

PSA tools docs #9963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 7, 2019
Merged

PSA tools docs #9963

merged 4 commits into from
Mar 7, 2019

Conversation

orenc17
Copy link
Contributor

@orenc17 orenc17 commented Mar 6, 2019

Description

Create documentation for all the PSA python tools & scripts.

This PR depends on:

Do not run CI untill all of the above are merged

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[X] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@mikisch81 @ARMmbed/mbed-os-maintainers

Release Notes

@ciarmcom ciarmcom requested review from mikisch81 and a team March 6, 2019 18:00
@ciarmcom
Copy link
Member

ciarmcom commented Mar 6, 2019

@orenc17, thank you for your changes.
@mikisch81 @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.


`release.py` is the script assigned with compiling the secure images.

```python
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this code block contains python

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, removed that

@ghost ghost added the PM_ACCEPTED label Mar 6, 2019
each implementation requires a set of auto generated files describing the secure partitions.

* `generate_partition_code.py` - Generate files for both implementations.
* `generate_mbed_spm_partition_code.py` - Generate files for BMED_SPM.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to know what BMED_SPM is 😁

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2vecn2

each implementation requires a set of auto generated files describing the secure partitions.

* `generate_partition_code.py` - Generate files for both implementations.
* `generate_mbed_spm_partition_code.py` - Generate files for BMED_SPM.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A question about the script name.

Is there a reason it's named generate_mbed_spm_partition_code.py instead of generate_spm_partition_code.py?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Branding

Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo needs fixing.

Edit file for minor grammar and style tweaks, mostly for consistent capitalization and tense across docs.
@orenc17
Copy link
Contributor Author

orenc17 commented Mar 7, 2019

@AnotherButler thanks

@cmonr
Copy link
Contributor

cmonr commented Mar 7, 2019

CI started

@cmonr
Copy link
Contributor

cmonr commented Mar 7, 2019

@NirSonnenschein If you want to take a look at this, or press the green button yourself 😁

@NirSonnenschein NirSonnenschein merged commit aedc1e1 into ARMmbed:master Mar 7, 2019
@NirSonnenschein
Copy link
Contributor

Thanks @cmonr merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants