Skip to content

PSA: Fix psa/release.py tool #9978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2019
Merged

PSA: Fix psa/release.py tool #9978

merged 1 commit into from
Mar 7, 2019

Conversation

orenc17
Copy link
Contributor

@orenc17 orenc17 commented Mar 7, 2019

Description

Fix a python variable name that's causing a crash

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@mikisch81

Release Notes

@NirSonnenschein
Copy link
Contributor

urgent fix for PSA release script

@orenc17 orenc17 changed the title Fix psa/release.py tool PSA: Fix psa/release.py tool Mar 7, 2019
@0xc0170 0xc0170 requested a review from a user March 7, 2019 13:28
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 7, 2019

CI started

cmonr
cmonr approved these changes Mar 7, 2019
View reviewed changes
Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮

@cmonr
Copy link
Contributor

cmonr commented Mar 7, 2019

@orenc17 This makes me thing of something.

Are the new PSA scripts being tested in any way aside for manually?

ghost
ghost approved these changes Mar 7, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meets criteria, PSA related. Approved.

@ghost ghost added the PM_ACCEPTED label Mar 7, 2019
@mbed-ci
Copy link

mbed-ci commented Mar 7, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@cmonr
Copy link
Contributor

cmonr commented Mar 7, 2019

Bringing this in, but @orenc17 would still like an answer to #9978 (comment)

@cmonr cmonr merged commit 277c91f into ARMmbed:master Mar 7, 2019
@cmonr cmonr removed the needs: CI label Mar 7, 2019
@orenc17
Copy link
Contributor Author

orenc17 commented Mar 7, 2019

@cmonr the code generating scripts already have pytest committed

@mikisch81 mikisch81 mentioned this pull request Mar 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@NirSonnenschein NirSonnenschein NirSonnenschein approved these changes

Assignees
No one assigned
Labels
release-version: 5.12.0-rc2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@orenc17 @NirSonnenschein @0xc0170 @cmonr @mbed-ci