Skip to content

Space-Time AStar #1170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Feb 25, 2025
Merged

Conversation

SchwartzCode
Copy link
Contributor

@SchwartzCode SchwartzCode commented Feb 20, 2025

Reference issue

What does this implement/fix?

This implements SpaceTime A* as outlined in this paper:
https://www.davidsilver.uk/wp-content/uploads/2020/03/coop-path-AIWisdom.pdf

This is a variant of A* that works with dynamic obstacles. I wanted to implement this to serve as a baseline before implementing Safe Interval Path Planning, which is a clever path planning algorithm that greatly reduces the number of node expansions in problems with dynamic obstacles.

Some examples of the SpaceTime A* algorithm running:

random_scenario

scenario1

Additional information

CheckList

  • Did you add an unittest for your new example or defect fix?
  • Did you add documents for your new example?
  • All CIs are green? (You can check it after submitting)

@SchwartzCode
Copy link
Contributor Author

I didn't find a home for path planning algorithms with dynamic obstacles, let me know if there is somewhere better for this to live :)

I used ruff format to format these files, is there something else I should use?

I also didn't look at all of the CI jobs - will come back to address those tomorrow (it's time for sleep where I'm at)

@AtsushiSakai
Copy link
Owner

AtsushiSakai commented Feb 20, 2025

@SchwartzCode Thank you for great PR!! I loved it.

let me know if there is somewhere better for this to live :)

Creating a new directory under here:
https://github.com/AtsushiSakai/PythonRobotics/tree/master/PathPlanning
is fine for me.

I used ruff format to format these files, is there something else I should use?

I think it is enough, but please check all CIs are green.

I also didn't look at all of the CI jobs - will come back to address those tomorrow (it's time for sleep where I'm at)

I think all CIs are running, but some are failed,

image

@SchwartzCode
Copy link
Contributor Author

@AtsushiSakai Glad you like the PR! I fixed the CI

Copy link
Owner

@AtsushiSakai AtsushiSakai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. @SchwartzCode I have 2 additional requests.

1
Could you please create a PR to add the gifs for this repository?
https://github.com/AtsushiSakai/PythonRoboticsGifs

2
Is it possible to add documentation for this new script based on the manual?
https://atsushisakai.github.io/PythonRobotics/modules/0_getting_started/3_how_to_contribute.html#step-4-write-a-document-about-the-algorithm

@SchwartzCode
Copy link
Contributor Author

PR into the gifs repo: AtsushiSakai/PythonRoboticsGifs#6

@SchwartzCode
Copy link
Contributor Author

Added a short doc entry here: 451e545

Copy link
Owner

@AtsushiSakai AtsushiSakai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I have additional comments and questions. PTAL,

Copy link
Owner

@AtsushiSakai AtsushiSakai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!. @SchwartzCode After, all CIs are green, I will merge this.

@AtsushiSakai AtsushiSakai merged commit 0c8ff11 into AtsushiSakai:master Feb 25, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants