Skip to content

Get correct PSVersion from PowerShell runtime #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 26, 2021
Merged

Get correct PSVersion from PowerShell runtime #278

merged 1 commit into from
Jul 26, 2021

Conversation

dingmeng-xue
Copy link
Member

@dingmeng-xue dingmeng-xue commented Jul 26, 2021 •
edited
Loading

PSVersion previously is fetch via $Host.Version. After discussion with PowerShell team, the correct way is $Host.Runspace.Version. So, it changes below codes:

  • Get correct PowerShell version via $Host.Runspace.Version in PowerShell scripts
  • Keep host name and version into new telemetry properties
  • Add additional information into telemetry debug message
  • Clean deprecated code.

@dingmeng-xue dingmeng-xue requested a review from isra-fel July 26, 2021 08:08
isra-fel
isra-fel approved these changes Jul 26, 2021
View reviewed changes
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VeryEarly VeryEarly merged commit 71f94c8 into main Jul 26, 2021
This was referenced Jul 26, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isra-fel isra-fel isra-fel approved these changes

@VeryEarly VeryEarly VeryEarly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dingmeng-xue @isra-fel @VeryEarly