Skip to content

Add PowerShell version into telemetry #15546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 28, 2021

Conversation

dingmeng-xue
Copy link
Member

@dingmeng-xue dingmeng-xue commented Jul 26, 2021

Description

Following update Azure/azure-powershell-common#278 and upgrade common lib to the newer version.

For support autogen based cmdlet, populate required properties in TelemetryProvider.cs
In addition, this PR adjusts the log of autogen based cmdlet to make it consistent with SDK based cmdlet

One limitation is PowerShell version cannot be fetched if SDK based cmdlet is not executed. It is due to the version of PowerShell needs to be fetch via PowerSHell scripts but runspace is not available in AzModule. I created a bug Azure/autorest.powershell#810 to track it.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@dingmeng-xue dingmeng-xue added this to the Jul 2021 (2021-08-03) milestone Jul 26, 2021
isra-fel
isra-fel previously approved these changes Jul 26, 2021
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isra-fel isra-fel self-assigned this Jul 26, 2021
@dingmeng-xue
Copy link
Member Author

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@isra-fel
Copy link
Member

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@isra-fel isra-fel changed the base branch from main to release-2021-08-03 July 27, 2021 06:14
@isra-fel isra-fel dismissed their stale review July 27, 2021 06:14

The base branch was changed.

@dingmeng-xue dingmeng-xue merged commit ad87106 into Azure:release-2021-08-03 Jul 28, 2021
dolauli added a commit that referenced this pull request Aug 2, 2021
* [Blockchain] Merge blockchain to release-2021-08-03 branch (#15560)

* Move Blockchain to main

* Update ChangeLog.md

* Update Az.Blockchain.psd1 (#15558)

Co-authored-by: azurepowershell <[email protected]>

* Fix typo in Az.Storage changelog (#15563)

* Generate Az.PostgreSQL (#15555)

* Move PostgreSQL to main

* changelog

Co-authored-by: azurepowershell <[email protected]>

* Add PowerShell version into telemetry (#15546)

* Add PowerShell version into telemetry

* Update changelog

* Add dummy code

* Remove local test libs

* Revert "[Storage] Support Parquet in Quick query (#15539)" (#15568)

This reverts commit 862d3c4.

Co-authored-by: Dingmeng Xue <[email protected]>

* Customize testgallery as the source of dotnet reference docs (#15570)

* RC2

* customize testgallery as the source of dotnet reference docs

* Revert "RC2"

This reverts commit 827eab5.

Co-authored-by: Yeming Liu <[email protected]>

* [Az.Migrate] Tagging bug fix (#15573)

* Move Migrate to release-2021-08-03

* Update GeneratedModuleList.txt

remove duplicated postgresql entry

Co-authored-by: azurepowershell <[email protected]>

* August 2021 RC3

Co-authored-by: Xiaogang <[email protected]>
Co-authored-by: azurepowershell <[email protected]>
Co-authored-by: Dingmeng Xue <[email protected]>
Co-authored-by: Wei Wei <[email protected]>
Co-authored-by: Beisi Zhou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants