Skip to content

Create Managed Network Powershell #10195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Oct 24, 2019
Merged

Create Managed Network Powershell #10195

merged 18 commits into from
Oct 24, 2019

Conversation

yanfa317
Copy link
Contributor

@yanfa317 yanfa317 commented Oct 4, 2019 •
edited by isra-fel
Loading

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • Azure/azure-powershell-cmdlet-review-pr#369
    • the markdown help files have been regenerated using the commands listed here

@adxsdkps
Copy link
Collaborator

adxsdkps commented Oct 4, 2019

Can one of the admins verify this patch?

@markcowl
Copy link
Member

markcowl commented Oct 4, 2019

@yanfa317 Please link to your cmdlet review in the PR comments

@yanfa317
Copy link
Contributor Author

yanfa317 commented Oct 4, 2019

@markcowl https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/369
Thanks!

@yanfa317
Copy link
Contributor Author

yanfa317 commented Oct 7, 2019

@adxsdkps We verified that this PR is from MNC team to create powershell for MNC

@yanfa317
Copy link
Contributor Author

yanfa317 commented Oct 7, 2019

@markcowl Can you help us to check why the checks failed? It seems that it is because of "Set-Variable -Name ProgressPreference -Value 'SilentlyContinue';. D:\a\1\s\tools//GenerateHelp.ps1 -ValidateMarkdownHelp -GenerateMamlHelp -BuildConfig Debug" Thanks!

@yanfa317
Copy link
Contributor Author

@markcowl Can you help us review it? Thanks!

@isra-fel isra-fel assigned wyunchi-ms and unassigned yanfa317 Oct 16, 2019
@yanfa317
Copy link
Contributor Author

Hi, @wyunchi-ms Can you help us review this RP? And do you know why checks are keeping in state of "In process" for more than 24 hours? But in detail page of azure piplines, it seems that all of them have finished. Thanks!

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@yanfa317
Copy link
Contributor Author

@wyunchi-ms @isra-fel Thanks so much! Can you help us to review this PR? We would like to close it as soon as possbile. Thanks again!

isra-fel
isra-fel reviewed Oct 21, 2019
View reviewed changes
isra-fel
isra-fel requested changes Oct 21, 2019
View reviewed changes
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments. Not finished yet. Will update tomorrow.

@yanfa317
Copy link
Contributor Author

@isra-fel Thanks for your comments! I have fixed the code based on them. There is one quesions: why do we want stirng [] instead of list? Also, please help us review it again. Thanks so much!

@isra-fel
Copy link
Member

isra-fel commented Oct 23, 2019 •
edited
Loading

@isra-fel Thanks for your comments! I have fixed the code based on them. There is one quesions: why do we want stirng [] instead of list? Also, please help us review it again. Thanks so much!

An array is eaiser to create and manipulate in powershell thant a list. It's a general rule in our design guideline that every cmdlet should follow.
I'll do the review today.

isra-fel
isra-fel requested changes Oct 23, 2019
View reviewed changes
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments.
@yanfa317 those 3 files under tools/ are for debug I believe? Could you remove them?

@isra-fel isra-fel assigned yanfa317 and unassigned isra-fel and wyunchi-ms Oct 23, 2019
@isra-fel
Copy link
Member

isra-fel commented Oct 23, 2019 •
edited
Loading

One moe thing -- Az.ManagedNetwork.md needs to be regenerated, too. Please make sure all the placeholders ({{...}}) are replaced by either regenerating or hand-writing. Thanks

@yanfa317
Copy link
Contributor Author

@isra-fel Removed 3 files in tools. And delete online help link in Az.ManagedNetwork.md since we don't have help page yet

isra-fel
isra-fel requested changes Oct 24, 2019
View reviewed changes
@isra-fel isra-fel assigned isra-fel and unassigned yanfa317 Oct 24, 2019
@isra-fel isra-fel merged commit 1ab38fb into Azure:master Oct 24, 2019
@isra-fel isra-fel mentioned this pull request Oct 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isra-fel isra-fel isra-fel approved these changes

Assignees

@isra-fel isra-fel

Labels
Cmdlet Review Complete Waiting for CI :shipit:
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@yanfa317 @adxsdkps @markcowl @wyunchi-ms @isra-fel @azuresdkci @michaelRoos