Skip to content

Revert "Create Managed Network Powershell" #10392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2019
Merged

Conversation

isra-fel
Copy link
Member

Reverts #10195

This is for public preview.
Code is now on branch Az.ManagedNetwork-Preview.

@isra-fel isra-fel requested a review from wyunchi-ms October 25, 2019 04:30
@isra-fel isra-fel self-assigned this Oct 25, 2019
@adxsdkps
Copy link
Collaborator

Can one of the admins verify this patch?

@isra-fel
Copy link
Member Author

@yanfa317 FYI

Copy link
Member

@markcowl markcowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to do this. All modules < 1.0 are previews, and belong in the master branch. Only modules with stable versions need to target separate preview branches.

Copy link
Member

@markcowl markcowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One extra file to delete, and looks like one insertion that was not needed

@@ -1,2 +0,0 @@
"AssemblyFileName","ClassName","Target","Severity","ProblemId","Description","Remediation"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems liek this file should be completedlt removed. Also, the 'PS-VSPrompt.lnk file above should not be included in this PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markcowl
Yes, SignatureIssues.csv is indeed deleted.

"PS-VSPrompt.lnk" was deleted by accident in the original PR. This PR will recover it back.

@markcowl markcowl removed their assignment Oct 28, 2019
@wyunchi-ms wyunchi-ms merged commit 7168e64 into master Oct 28, 2019
@isra-fel isra-fel deleted the revert-10195-master branch October 29, 2019 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants