-
Notifications
You must be signed in to change notification settings - Fork 4k
Revert "Create Managed Network Powershell" #10392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can one of the admins verify this patch? |
@yanfa317 FYI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need to do this. All modules < 1.0 are previews, and belong in the master branch. Only modules with stable versions need to target separate preview branches.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One extra file to delete, and looks like one insertion that was not needed
@@ -1,2 +0,0 @@ | |||
"AssemblyFileName","ClassName","Target","Severity","ProblemId","Description","Remediation" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems liek this file should be completedlt removed. Also, the 'PS-VSPrompt.lnk file above should not be included in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@markcowl
Yes, SignatureIssues.csv
is indeed deleted.
"PS-VSPrompt.lnk" was deleted by accident in the original PR. This PR will recover it back.
Reverts #10195
This is for public preview.
Code is now on branch
Az.ManagedNetwork-Preview
.