Skip to content

Remove deprecated Vulnerability Assessment and Threat Protection Aliases #10361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 44 commits into from
Oct 29, 2019

Conversation

yoavfr
Copy link
Contributor

@yoavfr yoavfr commented Oct 23, 2019

Description

Remove deprecated Vulnerability Assessment and Threat Protection Aliases.
Please note that auto-generating the markdown produces changes that are not related to my changes, so I cherry picked what I found relevant.
This change was requested by Yunchi Wang

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@adxsdkps
Copy link
Collaborator

Can one of the admins verify this patch?

@wyunchi-ms wyunchi-ms self-assigned this Oct 23, 2019
jaredmoo
jaredmoo previously approved these changes Oct 23, 2019
jaredmoo
jaredmoo previously approved these changes Oct 24, 2019
@wyunchi-ms
Copy link
Contributor

/azp run azure-powershell - powershell-core

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@yoavfr
Copy link
Contributor Author

yoavfr commented Oct 28, 2019

Hi @yoavfr could you please take a look at the CI? Some of the test failed. Thanks!

The tests passed a couple days ago for my changes. Not sure what has changed.
If I understand the logs correctly - the failures are in TestVirtualNetworkeExpressRouteGatewayConnectionCRUD - "Breaking changes in the cmdlet 'New-AzVirtualNetworkSubnetConfig'". I haven't made any changes to this. Is the pipeline broken?

Looks like a merge conflict issue....

@yoavfr
Copy link
Contributor Author

yoavfr commented Oct 28, 2019

Hi @wyunchi-ms would appreciate if you could review before another conflicting commit causes failures again

@wyunchi-ms wyunchi-ms merged commit e691949 into master Oct 29, 2019
@wyunchi-ms wyunchi-ms deleted the removeDeprecatedVaAliases branch January 10, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants