Skip to content

Remove deprecated Vulnerability Assessment and Threat Protection Aliases #10361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 44 commits into from
Oct 29, 2019
Merged

Remove deprecated Vulnerability Assessment and Threat Protection Aliases #10361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
d9b1951
Remove deprecated Vulnerability Assessment Aliases and Add aliases to…
yoavfr Oct 23, 2019
ebebc9e
Update Documentation
yoavfr Oct 23, 2019
97cc2e3
remove dead help file
yoavfr Oct 23, 2019
f771a92
Fix tabulation
yoavfr Oct 23, 2019
eb45a74
Fix tests
yoavfr Oct 23, 2019
5b463c8
more help fixes
yoavfr Oct 23, 2019
09cbc08
Merge branch 'master' into removeDeprecatedVaAliases
yoavfr Oct 24, 2019
f8f21a3
Update breaking changes
yoavfr Oct 24, 2019
1625b60
Add signature exceptions
yoavfr Oct 24, 2019
be2afbb
more test and documentation fixes
yoavfr Oct 24, 2019
053ac93
Fix ThreatDetectionTests
yoavfr Oct 24, 2019
4b85d44
Merge branch 'master' into removeDeprecatedVaAliases
yoavfr Oct 25, 2019
f8fd265
fix breaking expected changes and output analyzer to stdout
yoavfr Oct 25, 2019
7170333
Merge branch 'master' into removeDeprecatedVaAliases
yoavfr Oct 25, 2019
83d8a3f
fix merge
yoavfr Oct 25, 2019
1fdfaf3
Fix the merge
yoavfr Oct 25, 2019
37d0732
Merge branch 'master' into removeDeprecatedVaAliases
yoavfr Oct 25, 2019
a4cfdd5
Remove Get-AzSqlDatabaseSecureConnectionPolicy cmdlet
ayeletshpigelman Oct 24, 2019
326e8a9
Update BreakingChangesIssues regarding Get-AzSqlDatabaseSecureConnect…
ayeletshpigelman Oct 25, 2019
a3e84dc
Update BreakingChangeIssues.csv
ayeletshpigelman Oct 25, 2019
9a2c3ce
Update BreakingChangeIssues.csv
ayeletshpigelman Oct 25, 2019
e62ffbc
Add proxy support for private link service and private endpoint conne…
bowen0106 Oct 15, 2019
6b20aa2
1. Change PrivateEndpointConnection cmdlets logics to support generic…
bowen0106 Oct 17, 2019
f5d4fd3
Update help files and changelog file.
bowen0106 Oct 17, 2019
d3193a1
Changes/improvements for resolving the PR comments
bowen0106 Oct 18, 2019
2627a7b
Rename 'ResoureType' to 'PrivateLinkResourceType' and add 'PrivateLin…
bowen0106 Oct 21, 2019
0efdc89
Update help files.
bowen0106 Oct 21, 2019
6db6ce4
Fix test issue. local test pass.
bowen0106 Oct 21, 2019
1114e11
Update SDK
anton-evseev Oct 22, 2019
c60b29f
Use Network SDK from NuGet
anton-evseev Oct 23, 2019
35a9e3e
Try to fix the Static Analysis issue from CI.
bowen0106 Oct 24, 2019
9fb1ec3
Change sql version to 1.36.
bowen0106 Oct 24, 2019
0ad84c5
Bump up Sql version in Sql side.
bowen0106 Oct 24, 2019
87fe571
Update test for sql login and pass.
bowen0106 Oct 24, 2019
67b01fe
Add test record.
bowen0106 Oct 24, 2019
c7ca96f
Modify test for playback mode.
bowen0106 Oct 24, 2019
da90787
Added the deprecated parameters back to bypass Static Analysis.
bowen0106 Oct 25, 2019
347a2d6
Add sql.dll to require assemblies in psd1 file.
bowen0106 Oct 25, 2019
6b8125b
Re-record test and modify test code. Remove exceptions introduced bef…
bowen0106 Oct 25, 2019
9226c7a
Delele the function that already define in common.ps1.
bowen0106 Oct 25, 2019
96db916
merge from master
yoavfr Oct 28, 2019
8d6f08b
Update changelog
yoavfr Oct 28, 2019
5fbc757
Fix breaking change issues
yoavfr Oct 28, 2019
2be77d8
Merge branch 'master' into removeDeprecatedVaAliases
yoavfr Oct 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Sql/Sql.Test/ScenarioTests/AdvancedDataSecurityManagedInstanceTests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ function Test-AdvancedDataSecurityPolicyManagedInstanceTest
Assert-True { $policy.IsEnabled }

# Validate the VA policy
$settings = Get-AzSqlInstanceVulnerabilityAssessmentSettings -ResourceGroupName $params.rgname -InstanceName $params.serverName
$settings = Get-AzSqlInstanceVulnerabilityAssessmentSetting -ResourceGroupName $params.rgname -InstanceName $params.serverName
Assert-AreEqual $params.rgname $settings.ResourceGroupName
Assert-AreEqual $params.serverName $settings.InstanceName
Assert-AreEqual "vulnerability-assessment" $settings.ScanResultsContainerName
Expand Down
14 changes: 7 additions & 7 deletions src/Sql/Sql.Test/ScenarioTests/AdvancedDataSecurityTests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,12 +52,12 @@ function Test-AdvancedDataSecurityPolicyTest
Assert-False { $policy.IsEnabled }

# See that ATP cmdlets don't mess up the Threat Detection policy - with enabling VA off
Update-AzSqlServerAdvancedThreatProtectionSettings -ResourceGroupName $params.rgname -ServerName $params.serverName -NotificationRecipientsEmails "[email protected];[email protected]" -EmailAdmins $false -ExcludedDetectionType Sql_Injection_Vulnerability
Update-AzSqlServerAdvancedThreatProtectionSetting -ResourceGroupName $params.rgname -ServerName $params.serverName -NotificationRecipientsEmails "[email protected];[email protected]" -EmailAdmins $false -ExcludedDetectionType Sql_Injection_Vulnerability

Disable-AzSqlServerAdvancedDataSecurity -ResourceGroupName $params.rgname -ServerName $params.serverName

# Assert
$policy = Get-AzSqlServerAdvancedThreatProtectionSettings -ResourceGroupName $params.rgname -ServerName $params.serverName
$policy = Get-AzSqlServerAdvancedThreatProtectionSetting -ResourceGroupName $params.rgname -ServerName $params.serverName
Assert-AreEqual $policy.ThreatDetectionState "Disabled"
Assert-AreEqual $policy.NotificationRecipientsEmails "[email protected];[email protected]"
Assert-False {$policy.EmailAdmins}
Expand All @@ -67,7 +67,7 @@ function Test-AdvancedDataSecurityPolicyTest
Enable-AzSqlServerAdvancedDataSecurity -ResourceGroupName $params.rgname -ServerName $params.serverName -DoNotConfigureVulnerabilityAssessment

# Assert
$policy = Get-AzSqlServerAdvancedThreatProtectionSettings -ResourceGroupName $params.rgname -ServerName $params.serverName
$policy = Get-AzSqlServerAdvancedThreatProtectionSetting -ResourceGroupName $params.rgname -ServerName $params.serverName
Assert-AreEqual $policy.ThreatDetectionState "Enabled"
Assert-AreEqual $policy.NotificationRecipientsEmails "[email protected];[email protected]"
Assert-False {$policy.EmailAdmins}
Expand All @@ -85,7 +85,7 @@ function Test-AdvancedDataSecurityPolicyTest
Assert-True { $policy.IsEnabled }

# Validate the VA policy
$settings = Get-AzSqlServerVulnerabilityAssessmentSettings -ResourceGroupName $params.rgname -ServerName $params.serverName
$settings = Get-AzSqlServerVulnerabilityAssessmentSetting -ResourceGroupName $params.rgname -ServerName $params.serverName
Assert-AreEqual $params.rgname $settings.ResourceGroupName
Assert-AreEqual $params.serverName $settings.ServerName
Assert-AreEqual "vulnerability-assessment" $settings.ScanResultsContainerName
Expand All @@ -95,12 +95,12 @@ function Test-AdvancedDataSecurityPolicyTest
Assert-AreEqualArray @() $settings.NotificationEmail

# See that ATP cmdlets don't mess up the Threat Detection policy - with enabling VA on
Update-AzSqlServerAdvancedThreatProtectionSettings -ResourceGroupName $params.rgname -ServerName $params.serverName -NotificationRecipientsEmails "[email protected];[email protected]" -EmailAdmins $false -ExcludedDetectionType Sql_Injection_Vulnerability
Update-AzSqlServerAdvancedThreatProtectionSetting -ResourceGroupName $params.rgname -ServerName $params.serverName -NotificationRecipientsEmails "[email protected];[email protected]" -EmailAdmins $false -ExcludedDetectionType Sql_Injection_Vulnerability

Disable-AzSqlServerAdvancedDataSecurity -ResourceGroupName $params.rgname -ServerName $params.serverName

# Assert
$policy = Get-AzSqlServerAdvancedThreatProtectionSettings -ResourceGroupName $params.rgname -ServerName $params.serverName
$policy = Get-AzSqlServerAdvancedThreatProtectionSetting -ResourceGroupName $params.rgname -ServerName $params.serverName
Assert-AreEqual $policy.ThreatDetectionState "Disabled"
Assert-AreEqual $policy.NotificationRecipientsEmails "[email protected];[email protected]"
Assert-False {$policy.EmailAdmins}
Expand All @@ -110,7 +110,7 @@ function Test-AdvancedDataSecurityPolicyTest
Enable-AzSqlServerAdvancedDataSecurity -ResourceGroupName $params.rgname -ServerName $params.serverName -DeploymentName "EnableVA_sql-ads-cmdlet-test-srv2"

# Assert
$policy = Get-AzSqlServerAdvancedThreatProtectionSettings -ResourceGroupName $params.rgname -ServerName $params.serverName
$policy = Get-AzSqlServerAdvancedThreatProtectionSetting -ResourceGroupName $params.rgname -ServerName $params.serverName
Assert-AreEqual $policy.ThreatDetectionState "Enabled"
Assert-AreEqual $policy.NotificationRecipientsEmails "[email protected];[email protected]"
Assert-False {$policy.EmailAdmins}
Expand Down
8 changes: 4 additions & 4 deletions src/Sql/Sql.Test/ScenarioTests/ThreatDetectionClassicStorageTests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ function Test-ThreatDetectionUpdatePolicyWithClassicStorage
try
{
# Test - database policy
Set-AzSqlDatabaseThreatDetectionPolicy -ResourceGroupName $params.rgname -ServerName $params.serverName -DatabaseName $params.databaseName -NotificationRecipientsEmails "[email protected]" -EmailAdmins $false -ExcludedDetectionType "Sql_Injection_Vulnerability" -StorageAccountName $params.storageAccount
$policy = Get-AzSqlDatabaseThreatDetectionPolicy -ResourceGroupName $params.rgname -ServerName $params.serverName -DatabaseName $params.databaseName
Set-AzSqlDatabaseThreatDetectionSetting -ResourceGroupName $params.rgname -ServerName $params.serverName -DatabaseName $params.databaseName -NotificationRecipientsEmails "[email protected]" -EmailAdmins $false -ExcludedDetectionType "Sql_Injection_Vulnerability" -StorageAccountName $params.storageAccount
$policy = Get-AzSqlDatabaseThreatDetectionSetting -ResourceGroupName $params.rgname -ServerName $params.serverName -DatabaseName $params.databaseName

# Assert
Assert-AreEqual $policy.ThreatDetectionState "Enabled"
Expand All @@ -39,8 +39,8 @@ function Test-ThreatDetectionUpdatePolicyWithClassicStorage


# Test - server policy
Set-AzSqlServerThreatDetectionPolicy -ResourceGroupName $params.rgname -ServerName $params.serverName -NotificationRecipientsEmails "[email protected]" -EmailAdmins $false -ExcludedDetectionType Sql_Injection_Vulnerability -StorageAccountName $params.storageAccount
$policy = Get-AzSqlServerThreatDetectionPolicy -ResourceGroupName $params.rgname -ServerName $params.serverName
Set-AzSqlServerThreatDetectionSetting -ResourceGroupName $params.rgname -ServerName $params.serverName -NotificationRecipientsEmails "[email protected]" -EmailAdmins $false -ExcludedDetectionType Sql_Injection_Vulnerability -StorageAccountName $params.storageAccount
$policy = Get-AzSqlServerThreatDetectionSetting -ResourceGroupName $params.rgname -ServerName $params.serverName

# Assert
Assert-AreEqual $policy.ThreatDetectionState "Enabled"
Expand Down
Loading