Skip to content

[Compute] ProximityPlacementGroupId Update feature #10675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 12, 2019

Conversation

hyonholee
Copy link
Contributor

@hyonholee hyonholee commented Dec 7, 2019

Description

https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/431
('ColocationStatus' is not included in this PR, because of missing Swagger spec)

  • Add ProximityPlacementGroupId parameter to the following cmdlets:
    • Update-AzAvailabilitySet, Update-AzVM, Update-AzVmss
  • Change ProximityPlacementGroup parameter to ProximityPlacementGroupId parameter in New-AzVM and New-AzVmss.
    (ProximityPlacementGroup parameter is still supported as an alias)
  • Update help message for VM and VMSS priority.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@hyonholee hyonholee changed the title ProximityPlacementGroupId Update feature [Compute] ProximityPlacementGroupId Update feature Dec 7, 2019
@hyonholee
Copy link
Contributor Author

@wyunchi-ms I replied your questions. Please let me know if you have further concerns. Thanks.

@wyunchi-ms wyunchi-ms merged commit 12dee4a into Azure:master Dec 12, 2019
VeryEarly pushed a commit to VeryEarly/azure-powershell that referenced this pull request Dec 12, 2019
* ProximityPlacementGroupId Update feature

* Hide a breaking change introduced by SDK which changes Type to Type1.
wyunchi-ms pushed a commit that referenced this pull request Dec 12, 2019
* ProximityPlacementGroupId Update feature

* Hide a breaking change introduced by SDK which changes Type to Type1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants