Skip to content

Add typed objects for piping scenarios [breaking] #11184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 27, 2020

Conversation

mentat9
Copy link
Member

@mentat9 mentat9 commented Feb 25, 2020

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@mentat9 mentat9 requested review from pilor and markcowl February 25, 2020 20:38
@mentat9
Copy link
Member Author

mentat9 commented Feb 25, 2020

I can't find anything helpful about what checks failed. Log link doesn't point to any kind of log. Summary message shows no tests failed (build/test is all good locally in my dev environment). Any idea how to fix these?

@pilor
Copy link
Contributor

pilor commented Feb 25, 2020

I can't find anything helpful about what checks failed. Log link doesn't point to any kind of log. Summary message shows no tests failed (build/test is all good locally in my dev environment). Any idea how to fix these?

You have to click "view more details on azure pipelines" after clicking "details" next to the failures. It will provide a lot more info. Example link:
https://dev.azure.com/azure-sdk/public/_build/results?buildId=269928&view=logs&jobId=444c7613-ee09-5b43-2ab8-cd2ca43e60c8&j=444c7613-ee09-5b43-2ab8-cd2ca43e60c8&t=97e1aac7-3998-55f5-2c00-2380e6ded006

@wyunchi-ms wyunchi-ms self-assigned this Feb 26, 2020
@wyunchi-ms wyunchi-ms merged commit 666c152 into Azure:Az.Resources-preview Feb 27, 2020
shenglol added a commit to shenglol/azure-powershell that referenced this pull request Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants